Rockbox

Tasklist

FS#10502 - Adds DSP functionality to the test_codec plugin

Attached to Project: Rockbox
Opened by Jeffrey Goode (Blue_Dude) - Sunday, 09 August 2009, 02:10 GMT
Last edited by Thomas Martitz (kugel.) - Wednesday, 12 August 2009, 18:19 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch adds three menu items to the test_codec plugin. They mirror the existing three items but with DSP in the signal chain. Other than adding DSP processing, the menu items behave identically to the original menu items.

I've also included a bonus fix for dsp.c. There is no functional change, but I found when hunting a bug that putting the enum items in order helped troubleshooting immensely.

I also upnumbered the plugin API version.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Wednesday, 12 August 2009, 18:19 GMT
Reason for closing:  Accepted
Additional comments about closing:  Jeff committed it himself in r22279.
Comment by Jeffrey Goode (Blue_Dude) - Sunday, 09 August 2009, 02:17 GMT
Oops, the plugin version was upnumbered by someone else to the same value before this patch was posted. This one upnumbers it again.
Comment by Jeffrey Goode (Blue_Dude) - Tuesday, 11 August 2009, 06:26 GMT
This version loops back to the menu after running the test, with a new menu option to quit. This allows quick comparisons of DSP/non-DSP speed tests, for example.
Comment by Jeffrey Goode (Blue_Dude) - Tuesday, 11 August 2009, 06:29 GMT
Forgot to include plugins/SOURCES. Fixed.
Comment by Thomas Martitz (kugel.) - Wednesday, 12 August 2009, 13:35 GMT
plugins/SOURCES should *not* be included, it would make test_codec compile everytime (for releases and current builds).
Comment by Jeffrey Goode (Blue_Dude) - Wednesday, 12 August 2009, 14:00 GMT
You are absolutely correct. I included it as a convenience to make it easier to test. When it comes time to commit, it shouldn't be there.

Loading...