Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10506 - Don't compile crossfade on lowmem targets

Attached to Project: Rockbox
Opened by MichaelGiacomelli (saratoga) - Tuesday, 11 August 2009, 03:26 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Tuesday, 11 August 2009, 04:13 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Disables compiling various crossfade specific code in pcmbuf.c on low memory (AMS Sansa mainly) targets since this code is unused on them. Saves a bit under 2KB according to bloat-o-meter.

JdGordon suggested and I tend to agree that this should be made dependent on HAVE_CROSSFADE in the config-XXX.h files instead of just checking for MEMORYSIZE > 2.
   crossfade.patch (1.6 KiB) 
 apps/pcmbuf.c |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Tuesday, 11 August 2009, 04:13 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r22248.

Loading...