Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10514 - itunes compatible time setting

Attached to Project: Rockbox
Opened by Laurent Papier (papier) - Tuesday, 11 August 2009, 18:32 GMT+2
Last edited by Frank Gevaerts (fg) - Tuesday, 11 August 2009, 19:55 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds support for itunes time setting (special SCSI command over USB).

I have only tested it with my iPod mini2g and with ipod-time-sync tool from libgpod. But from the short discussion I had on IRC, it could works on other target too and with iTunes.

The USB code is taken from Frank Gevaerts patch found in FS#10023.
This task depends upon

Closed by  Frank Gevaerts (fg)
Tuesday, 11 August 2009, 19:55 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted as r22255
Comment by Laurent Papier (papier) - Tuesday, 11 August 2009, 18:35 GMT+2
missing patch
   rockbox-22236-usb-time-sync.patch (4.9 KiB) 
 firmware/usbstack/usb_storage.c |   40 +++++++++++++++++++++++++++++++++++++---
 firmware/include/timefuncs.h    |    2 ++
 firmware/common/timefuncs.c     |   39 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 78 insertions(+), 3 deletions(-)

Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 11 August 2009, 19:48 GMT+2
In yearday_to_daymonth():

Can't you move the ((y%4 == 0 && y%100 != 0) || y%400 == 0) check into if(yd <= t[i]) { ... }?

That way you'd only have to increase *d and not the whole t[] array..

Loading...