This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10541 - Wrong value used when changing scroll bar width
Attached to Project:
Rockbox
Opened by Rosso Maltese (asettico) - Tuesday, 18 August 2009, 15:35 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 16 December 2009, 07:02 GMT+2
Opened by Rosso Maltese (asettico) - Tuesday, 18 August 2009, 15:35 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 16 December 2009, 07:02 GMT+2
|
DetailsIn the "Scroll bar width" screen, the value used to show the width selected is the previous one, not the current one. The first value change has no effect.
Anyway it seems that the right value is stored: if you select a value and exit by the screen, when you re-enter in it, the width is correct. Priority low. Referred to r22406. |
This task depends upon
Perhaps a callback triggering a redraw of the current screen could solve this..
I'll leave this open for now though.
In this case, it's sufficient accept the new value and re-enter in the menu to see the changes.
@mcuelenaere: I tried to investigate somehow the settings list, comparing the behaviour with "Backlight" setting.
In this one, there is a callback function that use the selected value in the right way.
In the IRC discussion you indicated in http://www.rockbox.org/tracker/task/10541#comment32131, I can deduce that a callback doing a refresh of the UI is unacceptable or pointless, is it?
Also this could lead to a small glitch when going from the maximum scrollbar width to the smallest (the scrollbar would be drawed with the max width and the thumb at the top, then redrawed with the thumb at the bottom and then redrawed with the smallest width and the thumb at the bottom; the correct behaviour should leave out the second draw).
Thomas Martitz (kugel) proposed adding another flag (F_LIVEUPDATE) which would do all the above only if that flag was added, I tend to agree with him although that glitch is still there (but this is very minor).