Rockbox

Tasklist

FS#10548 - Cowon D2: Fix non-existing "yes" keymaps in yesno context

Attached to Project: Rockbox
Opened by Johannes Boy (joboy) - Wednesday, 19 August 2009, 13:52 GMT
Last edited by Thomas Martitz (kugel.) - Friday, 21 August 2009, 01:42 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

There apears to be no way to answer "yes" to a yes/no question, because the current keymapping in the struct "button_mapping button_context_yesno" is empty.
This patch marks the "BUTTON_TOPRIGHT" (default from "keymap-touchscreen.c") and the menu button to the "yes" context.
Since the D2 only has 3 buttons thats probably a save choice ;)
The patch must be applied to "apps/keymaps/keymap-cowond2.c".
It works with the ui simulator, not tested on the player yet.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 21 August 2009, 01:42 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks, committed with lang stuff in r22445.
Comment by Johannes Boy (joboy) - Wednesday, 19 August 2009, 13:59 GMT
Forgot to mention that the UI will still show "PLAY = Yes", as defined in english.lang (<source>"*: "PLAY = Yes"</source>); there appears to be no d2 target.
Comment by Johannes Boy (joboy) - Wednesday, 19 August 2009, 14:15 GMT
Well, here the version without the button_topright.

Loading...