Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10568 - Brickmania Lasers not working properly

Attached to Project: Rockbox
Opened by Hilton Shumway (HIllshum) - Friday, 28 August 2009, 18:41 GMT+2
Last edited by Karl Kurbjun (kkurbjun) - Friday, 18 December 2009, 04:37 GMT+2
Task Type Bugs
Category Plugins
Status Closed
Assigned To Karl Kurbjun (kkurbjun)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When playing brickmania, if one fires lasers from the paddle, then gets a 'N' or a 'G', those shots that were fired cease to work.
This task depends upon

Closed by  Karl Kurbjun (kkurbjun)
Friday, 18 December 2009, 04:37 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Asael Reiter (AsaelReiter) - Saturday, 05 September 2009, 23:14 GMT+2
Just remove the 'if' from line 1181. (r22636)
By the way, I think that this loop is monstrous and not effective.
Comment by Asael Reiter (AsaelReiter) - Thursday, 01 October 2009, 02:10 GMT+2
A diff file, in case that someone will commit it.

I still think that this loop have to been rewritten.
   bm.diff (2.6 KiB) 
 rockbox/apps/plugins/brickmania.c |   38 ++++++++++++++++++--------------------
 1 file changed, 18 insertions(+), 20 deletions(-)

Comment by Karl Kurbjun (kkurbjun) - Tuesday, 10 November 2009, 17:03 GMT+2
Asael,

Thanks for the patch, I will try to take a look at this later today, but offhand I think the fix looks appropriate. I agree that the game loop could definitely be re-written; it is not exactly efficient.
Comment by Hilton Shumway (HIllshum) - Friday, 18 December 2009, 00:37 GMT+2
That loop has been changed some, at that patch is out of sync. Bug still present however.
Comment by Asael Reiter (AsaelReiter) - Friday, 18 December 2009, 00:46 GMT+2
It's still a simple wrong "if".
try the attached file. (I didn't check it)
   bm.c (82.4 KiB)

Loading...