Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.3
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by captainkewl - 2009-08-30
Last edited by saratoga - 2009-08-30

FS#10570 - NSF Metadata

Metadata for NSFE .nsf files. Follows the convention used in the codec, which means that Copyright info goes into the Album tag.

   nsf-metadata.patch (1.7 KiB)
Closed by  saratoga
2009-08-30 02:53
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Accepted in r22557.

captainkewl commented on 2009-08-30 02:03

Oops. Forgot to svn add the nsf parser.

   nsf-metadata.patch (3.1 KiB)
saratoga commented on 2009-08-30 02:17

+ /* Use the trackname part of the id3 structure as a temporary buffer */
+ unsigned char buf[1084];

Comment and code don’t agree. Perhaps you copied this from SPC and forgot to change it?

+ if 1)) < 512))

Why is it necessary to read so many bytes? It looks like you only read up to byte 110.

1) lseek(fd, 0, SEEK_SET) < 0)
+ || ((read_bytes = read(fd, buf, sizeof(buf
captainkewl commented on 2009-08-30 02:40

Fixed inconsistencies.

   nsf-metadata.patch (3.1 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing