Rockbox

Tasklist

FS#10570 - NSF Metadata

Attached to Project: Rockbox
Opened by Jason Yu (captainkewl) - Sunday, 30 August 2009, 02:01 GMT
Last edited by MichaelGiacomelli (saratoga) - Sunday, 30 August 2009, 02:53 GMT
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Metadata for NSFE .nsf files. Follows the convention used in the codec, which means that Copyright info goes into the Album tag.
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Sunday, 30 August 2009, 02:53 GMT
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r22557.
Comment by Jason Yu (captainkewl) - Sunday, 30 August 2009, 02:03 GMT
Oops. Forgot to svn add the nsf parser.
Comment by MichaelGiacomelli (saratoga) - Sunday, 30 August 2009, 02:17 GMT
+ /* Use the trackname part of the id3 structure as a temporary buffer */
+ unsigned char buf[1084];

Comment and code don't agree. Perhaps you copied this from SPC and forgot to change it?

+ if ((lseek(fd, 0, SEEK_SET) < 0)
+ || ((read_bytes = read(fd, buf, sizeof(buf))) < 512))

Why is it necessary to read so many bytes? It looks like you only read up to byte 110.
Comment by Jason Yu (captainkewl) - Sunday, 30 August 2009, 02:40 GMT
Fixed inconsistencies.

Loading...