Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10570 - NSF Metadata

Attached to Project: Rockbox
Opened by Jason Yu (captainkewl) - Sunday, 30 August 2009, 04:01 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Sunday, 30 August 2009, 04:53 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Metadata for NSFE .nsf files. Follows the convention used in the codec, which means that Copyright info goes into the Album tag.
   nsf-metadata.patch (1.7 KiB) 
 apps/metadata/metadata_parsers.h |    2 ++
 apps/metadata.c                  |   12 ++----------
 apps/SOURCES                     |    1 +
 3 files changed, 5 insertions(+), 10 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Sunday, 30 August 2009, 04:53 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r22557.
Comment by Jason Yu (captainkewl) - Sunday, 30 August 2009, 04:03 GMT+2
Oops. Forgot to svn add the nsf parser.
   nsf-metadata.patch (3.1 KiB) 
 apps/metadata/metadata_parsers.h |    2 +
 apps/metadata/nsf.c              |   58 +++++++++++++++++++++++++++++++++++++++
 apps/metadata.c                  |   12 +-------
 apps/SOURCES                     |    1 
 4 files changed, 63 insertions(+), 10 deletions(-)

Comment by MichaelGiacomelli (saratoga) - Sunday, 30 August 2009, 04:17 GMT+2
+ /* Use the trackname part of the id3 structure as a temporary buffer */
+ unsigned char buf[1084];

Comment and code don't agree. Perhaps you copied this from SPC and forgot to change it?

+ if ((lseek(fd, 0, SEEK_SET) < 0)
+ || ((read_bytes = read(fd, buf, sizeof(buf))) < 512))

Why is it necessary to read so many bytes? It looks like you only read up to byte 110.
Comment by Jason Yu (captainkewl) - Sunday, 30 August 2009, 04:40 GMT+2
Fixed inconsistencies.
   nsf-metadata.patch (3.1 KiB) 
 apps/metadata/metadata_parsers.h |    2 +
 apps/metadata/nsf.c              |   59 +++++++++++++++++++++++++++++++++++++++
 apps/metadata.c                  |   12 +------
 apps/SOURCES                     |    1 
 4 files changed, 64 insertions(+), 10 deletions(-)

Loading...