Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10585 - c200: Brickmania ball moves very slowly and bonus items don't fall down

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Saturday, 05 September 2009, 04:38 GMT+2
Last edited by Bertrik Sikken (bertrik) - Thursday, 17 December 2009, 23:38 GMT+2
Task Type Bugs
Category Games
Status Closed
Assigned To Karl Kurbjun (kkurbjun)
Player Type Sansa c200
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

On sansa c200 and c200v2 in the brickmania game plugin, the ball moves very slowly. Also bonus items don't drop anymore, they just keep floating at the position of the brick they were in.

Reverting r22582 ("Brickmania: Make the game speed scale with the GAMESCREEN_HEIGHT") makes it work again.
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Thursday, 17 December 2009, 23:38 GMT+2
Reason for closing:  Fixed
Comment by Asael Reiter (AsaelReiter) - Sunday, 06 September 2009, 12:29 GMT+2
Confirmed on Sansa Clip.
Comment by Asael Reiter (AsaelReiter) - Sunday, 06 September 2009, 13:22 GMT+2
Try this:
   bm.diff (1.6 KiB) 
 apps/plugins/brickmania.c |   25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Sunday, 06 September 2009, 13:28 GMT+2
Some minor change.
   bm.diff (1.5 KiB) 
 apps/plugins/brickmania.c |   23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Thursday, 10 September 2009, 22:23 GMT+2
About the speed:
I think that some colossal loop is needed a faster CPU, so the game is slower than the supposed.
Before r22582, It was supposed to be very fast, so it became balanced.
In r22582, the speed was changed, (by the size of the screen), and from then, it's supposed to be normal, and, in actual fact, slow.

Some time ago, I write some code to replace that loop (It's in  FS#10485 , but there is many other changes there)
This code, caused brickmania become very fast (if I remember it correctly, I couldn't finish level 4)
But this was before r22582, and there was to many other changes, so auto-merging is impossible.
However, I can rewrite this part of the code, but it's still a large change, so I think that it's better that a develop will have a look.
Comment by Asael Reiter (AsaelReiter) - Friday, 18 September 2009, 16:13 GMT+2
I think that this file make it a bit better.
Still, there are a lot of think that can be improved. (And also some bugs that can be fixed)
   bm.diff (2.8 KiB) 
 rockbox/apps/plugins/brickmania.c |   29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

Comment by Karl Kurbjun (kkurbjun) - Tuesday, 10 November 2009, 18:11 GMT+2
Is this still a bug? The fixed point conversion should correct all of the problems smaller screens were seeing. The game loop could be faster, but it appears to be fast enough even with slower processors.
Comment by Bertrik Sikken (bertrik) - Thursday, 17 December 2009, 23:38 GMT+2
Works fine for me now on sansa clip and sansa c200.

Loading...