Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10589 - Wormlet: food can collide with arghs.

Attached to Project: Rockbox
Opened by Asael Reiter (AsaelReiter) - Sunday, 06 September 2009, 12:23 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 17 September 2009, 23:08 GMT+2
Task Type Bugs
Category Games
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When a food is created, only his corners are been checked, so if food_size is greater than argh_size, the food can cover an entire argh.
The argh doesn't been removed - just invisible (even after that the food is eaten).
   wl.diff (1.7 KiB) 
 apps/plugins/wormlet.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Thursday, 17 September 2009, 23:08 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Accepted in r22724. Thank you very much.

Your check seems simpler and more correct than the current code. I'm wondering if each collision check should do it this way.
Comment by Asael Reiter (AsaelReiter) - Wednesday, 09 September 2009, 15:02 GMT+2
This bug may happen also when a arch is created (if argh_size-food_size>=2).
I think that the attached file fixes it.
   wl.diff (3.9 KiB) 
 apps/plugins/wormlet.c |   50 ++++++++++++++++++++++++++-----------------------
 1 file changed, 27 insertions(+), 23 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Thursday, 17 September 2009, 22:55 GMT+2
As Kugel suggested, I wrote a macro to make it more simple.
   wl.diff (3.9 KiB) 
 apps/plugins/wormlet.c |   46 +++++++++++++++++++++++-----------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

Loading...