Rockbox

Tasklist

FS#10617 - %Cl and %C conditional viewport oddity

Attached to Project: Rockbox
Opened by Seheon Ryu (cpu98) - Friday, 25 September 2009, 15:08 GMT
Last edited by Jonathan Gordon (jdgordon) - Monday, 05 October 2009, 10:26 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

-------------------------------
%Cl|0|38|145|145|
%?C<%C%Vda|%Vdb>

Viewport b is used even if AA is not present.

-------------------------------
%Cl|0|38|145|145|

%?C<%C%Vda|%Vdb>

Viewport b is used when AA is not present.(expected behavior)

Really bugged me......
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 05 October 2009, 10:26 GMT
Reason for closing:  Fixed
Additional comments about closing:  shuold be fixed in r22944.
Comment by Seheon Ryu (cpu98) - Friday, 25 September 2009, 15:08 GMT
edit: Viewport b is used even if AA is not present. -> Viewport b is used even if AA is present.
Comment by Seheon Ryu (cpu98) - Friday, 25 September 2009, 15:12 GMT
%Cl|0|38|145|145|
%?C<%Vda|%Vdb>
Behaves as if it is given
%Cl|0|38|145|145|
%C
%V(viewport b)
Comment by Jonathan Gordon (jdgordon) - Friday, 25 September 2009, 16:34 GMT
whats the build number you are using? (menu > system > rockbox info: )
Comment by Seheon Ryu (cpu98) - Saturday, 26 September 2009, 10:11 GMT
Quite recent revision. 22827.
Need wps file for testing?
Comment by Teruaki Kawashima (teru) - Sunday, 27 September 2009, 13:05 GMT
i'm not sure if this is related to the bug.
skin_parser.c:1138: if ((wps_data->num_tokens > 1) && (prev->type == WPS_TOKEN_CONDITIONAL))
Shouldn't (wps_data->num_tokens > 1) be (wps_data->num_tokens >= 1) ?
Comment by Jonathan Gordon (jdgordon) - Sunday, 27 September 2009, 16:11 GMT
ah crud... yes... I forgot the Cl isnt stored as a token... I'll fix that this arvo

Loading...