Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10660 - add database tool to configure

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Wednesday, 07 October 2009, 14:52 GMT+2
Last edited by Frank Gevaerts (fg) - Wednesday, 07 October 2009, 20:17 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds support for building the database tool to configure, as a first step to get it in the autobuild system.

The only variables for the database tool should be endianness and charcell/bitmap, so allowing to build it per target may be seen as overkill.

(charcell/bitmap matters because unicode handling is different between those)
   db.patch (6.7 KiB) 
 tools/configure              |   13 ++++++++++++-
 tools/database/database.make |   42 ++++++++++++++++++++++++++++++++++++++++++
 tools/database/SOURCES       |   35 +++++++++++++++++++++++++++++++++++
 tools/database/database.c    |    1 +
 tools/root.make              |    2 ++
 tools/checkwps/checkwps.make |    3 ++-
 firmware/export/config.h     |    4 +---
 firmware/include/rbunicode.h |    2 --
 firmware/include/errno.h     |    2 +-
 9 files changed, 96 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Wednesday, 07 October 2009, 20:17 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r22998
Comment by Frank Gevaerts (fg) - Wednesday, 07 October 2009, 15:18 GMT+2
Now also builds properly for HWCODEC.

The patch also includes a semi-unrelated fix to configure that works around a recent gcc bug by not setting advanced optimisation flags for host-side tools (previously they were set the same as for the corresponding crosscompiler)
   db2.patch (6.9 KiB) 
 tools/configure              |   14 +++++++++++++-
 tools/database/database.make |   42 ++++++++++++++++++++++++++++++++++++++++++
 tools/database/SOURCES       |   37 +++++++++++++++++++++++++++++++++++++
 tools/database/database.c    |    1 +
 tools/root.make              |    2 ++
 tools/checkwps/checkwps.make |    3 ++-
 firmware/export/config.h     |    4 +---
 firmware/include/rbunicode.h |    2 --
 firmware/include/errno.h     |    2 +-
 9 files changed, 99 insertions(+), 8 deletions(-)

Comment by Dominik Riebeling (bluebrother) - Wednesday, 07 October 2009, 15:32 GMT+2
I remember mentioning this on IRC a while back and getting at least no negative comments: I'd prefer to move all of those options out of configure and instead having it as a build target. This already works for the manual: configure as (N)ormal, then use "make manual". Having this for all other tools might be more convenient, especially for users, as one could simply run "make rockbox zip manual checkwps database" or similar.
Comment by Frank Gevaerts (fg) - Wednesday, 07 October 2009, 16:07 GMT+2
I don't disagree, but I'm not sure how well the build system will handle this. Various *.make files set CFLAGS and similar, so always including them all may cause strange effects.

Loading...