Rockbox

Tasklist

FS#10673 - [PATCH] apps/gui/skin_engine/skin_tokens.c: Fix %Sp expansion in wps

Attached to Project: Rockbox
Opened by Junio C Hamano (gitster) - Monday, 12 October 2009, 22:03 GMT
Last edited by Thomas Martitz (kugel.) - Thursday, 15 October 2009, 22:24 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

[PATCH] apps/gui/skin_engine/skin_tokens.c: Fix %Sp expansion in wps

The value returned from sound_get_pitch() was shown assuming that 100%
corresponds to 1000 by skin_tokens.c::get_token_value(). The value
actually is 100*PITCH_SPEED_PRECISION.

Steal the way the callchain from gui_syncpitchscreen_run() to
pitchscreen_draw() in apps/gui/pitchscreen.c formats the value and use it
here for consistency.

This task depends upon

Closed by  Thomas Martitz (kugel.)
Thursday, 15 October 2009, 22:24 GMT
Reason for closing:  Accepted
Additional comments about closing:  Aplied in r23199. Thanks
Comment by Junio C Hamano (gitster) - Monday, 12 October 2009, 22:05 GMT
Sorry, it seems that I failed to attach the patch.
Comment by Thomas Martitz (kugel.) - Thursday, 15 October 2009, 22:24 GMT
Hehe, I almost git svn dcommit'ed it directly, but the path in the description and the fact that you're missing from docs/CREDITS prevented it :)

Loading...