Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10673 - [PATCH] apps/gui/skin_engine/skin_tokens.c: Fix %Sp expansion in wps

Attached to Project: Rockbox
Opened by Junio C Hamano (gitster) - Tuesday, 13 October 2009, 00:03 GMT+2
Last edited by Thomas Martitz (kugel.) - Friday, 16 October 2009, 00:24 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

[PATCH] apps/gui/skin_engine/skin_tokens.c: Fix %Sp expansion in wps

The value returned from sound_get_pitch() was shown assuming that 100%
corresponds to 1000 by skin_tokens.c::get_token_value(). The value
actually is 100*PITCH_SPEED_PRECISION.

Steal the way the callchain from gui_syncpitchscreen_run() to
pitchscreen_draw() in apps/gui/pitchscreen.c formats the value and use it
here for consistency.

This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 16 October 2009, 00:24 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Aplied in r23199. Thanks
Comment by Junio C Hamano (gitster) - Tuesday, 13 October 2009, 00:05 GMT+2
Sorry, it seems that I failed to attach the patch.
   0001-apps-gui-skin_engine-skin_tokens.c-Fix-Sp-ex... (1.4 KiB)
Comment by Thomas Martitz (kugel.) - Friday, 16 October 2009, 00:24 GMT+2
Hehe, I almost git svn dcommit'ed it directly, but the path in the description and the fact that you're missing from docs/CREDITS prevented it :)

Loading...