Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10683 - Cowon D2 track skipping on hold

Attached to Project: Rockbox
Opened by Koptelov Nikita (DaMaGeD) - Saturday, 17 October 2009, 14:35 GMT+2
Last edited by Rob Purchase (shotofadds) - Wednesday, 11 November 2009, 21:33 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

rev23223

In Cowon's OFW was function,that sets +\- buttons as next\prev track while keys are on hold.

That's implemention of all this on rockbox (soon will add another types of control,as there described:
http://www.iaudiophile.net/forums/showthread.php?t=28467 ).

In fact,this is rework of  FS#9875  with adding of setup menu.
   d2trackskipping_v1.patch (7.7 KiB) 
 apps/keymaps/keymap-cowond2.c                        |    5 +-
 apps/lang/english.lang                               |   42 +++++++++++++++++++
 apps/lang/russian.lang                               |   42 +++++++++++++++++++
 apps/menus/settings_menu.c                           |   12 +++++
 apps/settings.h                                      |    4 +
 apps/settings_list.c                                 |    5 ++
 firmware/target/arm/tcc780x/cowond2/button-cowond2.c |   25 +++++++++--
 firmware/target/arm/tcc780x/cowond2/button-target.h  |    5 ++
 utils/wpseditor/libwps/src/include/lang.h            |    1 
 9 files changed, 135 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Rob Purchase (shotofadds)
Wednesday, 11 November 2009, 21:33 GMT+2
Reason for closing:  Duplicate
Additional comments about closing:  Superceded by FS#10698
Comment by Alex Parker (BigBambi) - Saturday, 17 October 2009, 16:31 GMT+2
I agree - hold should disable keys, not change their functionality.
Comment by Koptelov Nikita (DaMaGeD) - Saturday, 17 October 2009, 16:40 GMT+2
(updated)
Found bug in MENU button,thinking about how workaround it.
When doing it in "normal" way(i.e.not that insane text in keypad config)-it won't work anymore.%)

Okay,stopping that FS#.
Comment by Rob Purchase (shotofadds) - Wednesday, 21 October 2009, 00:38 GMT+2
I actually support this idea and think it's a case where an option is desirable - indeed it should be disabled by default. It's not "configurable keymaps" per se, it's just enabling/disabling a feature.

I can't see what's wrong with making HOLD+<key> perform an action if the user has specifically enabled an option to make it do so.

Loading...