Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10692 - Viewpority USB screen

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Monday, 19 October 2009, 18:48 GMT+2
Last edited by Tomer Shalev (tomers) - Monday, 19 October 2009, 22:07 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch uses viewport to draw the USB screen
   viewportify_usb_screen.diff (6.9 KiB) 
 apps/screens.c |  176 +++++++++++++++++++++++++++++++++++++++------------------
 1 file changed, 123 insertions(+), 53 deletions(-)

This task depends upon

Closed by  Tomer Shalev (tomers)
Monday, 19 October 2009, 22:07 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in 23269.
Comment by Tomer Shalev (tomers) - Monday, 19 October 2009, 18:56 GMT+2
Updated patch (fix kugel's remarks)
   viewportify_usb_screen.diff (6 KiB) 
 apps/screens.c |  168 ++++++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 118 insertions(+), 50 deletions(-)

Comment by Tomer Shalev (tomers) - Monday, 19 October 2009, 19:50 GMT+2
Changes:
- Protect title with #ifdef
- Test whether USB logo fits the viewport, and use the entire screen if not
   viewportify_usb_screen.diff (6.2 KiB) 
 apps/screens.c |  178 ++++++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 128 insertions(+), 50 deletions(-)

Comment by Tomer Shalev (tomers) - Monday, 19 October 2009, 21:34 GMT+2
Last try before commit...
- Stop scrolling on exit
- Make it compile on player, which doesn't have LCD
   viewportify_usb_screen.diff (6.7 KiB) 
 apps/screens.c |  197 ++++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 148 insertions(+), 49 deletions(-)

Comment by Tomer Shalev (tomers) - Monday, 19 October 2009, 21:53 GMT+2
Yet another test
- Fix wrong #ifdef used
   viewportify_usb_screen.diff (6.7 KiB) 
 apps/screens.c |  197 ++++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 148 insertions(+), 49 deletions(-)

Loading...