Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10704 - Make a configuration option to disable USB HID

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Thursday, 22 October 2009, 00:15 GMT+2
Last edited by Tomer Shalev (tomers) - Friday, 23 October 2009, 15:45 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To Daniel Stenberg (bagder)
Player Type All players
Severity Critical
Priority Urgent
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Due to some OS not able to mount the DAP while USB HID is active (it is an OS bug, see  FS#10666 ), the need to be able to disable the HID USB driver emerged.

This configuration setting can be shared with usb_keypad_mode, setting this value to 0 means OFF.
   usb_hid_enabling_setting.diff (8.7 KiB) 
 apps/misc.h           |    7 +++++
 apps/screens.c        |   12 ---------
 apps/gui/usb_screen.c |   42 +++++++++++++++++++--------------
 apps/settings_list.c  |   10 +++----
 apps/usb_keymaps.c    |   63 ++++++++++++++++++++++++++++----------------------
 apps/misc.c           |   12 +++++++++
 firmware/usb.c        |    1 
 7 files changed, 86 insertions(+), 61 deletions(-)

This task depends upon

View Dependency Graph

This task blocks these from closing
 FS#10666 - Rockbox software USB doesn't connect with OS X 10.4 
Closed by  Tomer Shalev (tomers)
Friday, 23 October 2009, 15:45 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r23322.
Also in that commit a documentation part which includes the new feature, and a note of the OS X bug ( FS#10666 ), which suggest to disable USB HID in that case.
Comment by Turke (obzen) - Thursday, 22 October 2009, 22:16 GMT+2
Also effects Windows XP, using Nano 2G.
Comment by Turke (obzen) - Friday, 23 October 2009, 02:57 GMT+2
I've applied the patch, and it fixed my problem. Thanks a lot.
Comment by Turke (obzen) - Friday, 23 October 2009, 05:19 GMT+2
I guess i spoke early. The problem seems to be coming and going. For one take, i succesfully mounted the ipod, as a storage drive, but that was it. Later on, it just mounts as an empty usb device, with 0 capacity.
Comment by Tomer Shalev (tomers) - Friday, 23 October 2009, 15:13 GMT+2
This patch is complete, including documentation, and should soon be committed.
   usb_hid_enabling_setting.diff (13 KiB) 
 apps/misc.h                                 |    7 +++
 apps/screens.c                              |   12 -----
 apps/lang/english.lang                      |   17 +++++++
 apps/gui/usb_screen.c                       |   41 +++++++++++-------
 apps/settings.h                             |    1 
 apps/menus/settings_menu.c                  |    2 
 apps/settings_list.c                        |    2 
 apps/usb_keymaps.c                          |   62 +++++++++++++++-------------
 apps/misc.c                                 |   12 +++++
 firmware/export/usb.h                       |    4 +
 firmware/usb.c                              |   16 ++++++-
 manual/rockbox_interface/main.tex           |    5 ++
 manual/appendix/config_file_options.tex     |    5 ++
 manual/configure_rockbox/system_options.tex |    8 +++
 14 files changed, 137 insertions(+), 57 deletions(-)

Loading...