- Status Closed
- Percent Complete
- Task Type Patches
- Category Playlists
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.4
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10717 - Add PLAYLIST_INSERT_LAST_SHUFFLED functionality to onplay menu
This will Add PLAYLIST_INSERT_LAST_SHUFFLED functionality to onplay menu.
It mostly works but still needs testing. For example it is doesn’t make sense when playlist is empty or we are inserting just one track and doesn’t need to be displayed in such cases.
My question is: clean it further or leave it?
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Forgot patch file.
You also forgot the explain what PLAYLIST_INSERT_LAST_SHUFFLED is supposed to do. At least I didn’t get it.
Simply: You can add shuffled tracks to the end of dynamic playlist. Without this patch you can add tracks to the end of playlist, but not shuffled.
looks good… I tihnk its missing stuff so it adds the tracks to the .playlist_control file though?
Yes, it adds also to .playlist_control. In fact it uses “playlist API” and is doing everything same way like other playlist manipulating commands.
Tested and ready to commit version. Diff against r23340.
Added patch to manual also.
There is no make sense to display insert_last_shuffled option when just one track is selected.
Also some comments added.
Committed!