Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10717 - Add PLAYLIST_INSERT_LAST_SHUFFLED functionality to onplay menu

Attached to Project: Rockbox
Opened by Tomasz Kowalczyk (mitk) - Saturday, 24 October 2009, 19:53 GMT+2
Last edited by Dave Hooper (stripwax) - Wednesday, 28 October 2009, 23:28 GMT+2
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This will Add PLAYLIST_INSERT_LAST_SHUFFLED functionality to onplay menu.
It mostly works but still needs testing. For example it is doesn't make sense when playlist is empty or we are inserting just one track and doesn't need to be displayed in such cases.
My question is: clean it further or leave it?
This task depends upon

Closed by  Dave Hooper (stripwax)
Wednesday, 28 October 2009, 23:28 GMT+2
Reason for closing:  Accepted
Comment by Tomasz Kowalczyk (mitk) - Saturday, 24 October 2009, 19:55 GMT+2
Forgot patch file.
   insert_last_shuffled.patch (5.3 KiB) 
 apps/playlist.c        |   15 ++++++++++++++-
 apps/playlist.h        |    6 +++++-
 apps/lang/english.lang |   28 ++++++++++++++++++++++++++++
 apps/onplay.c          |   16 +++++++++++++++-
 4 files changed, 62 insertions(+), 3 deletions(-)

Comment by Thomas Martitz (kugel.) - Saturday, 24 October 2009, 21:23 GMT+2
You also forgot the explain what PLAYLIST_INSERT_LAST_SHUFFLED is supposed to do. At least I didn't get it.
Comment by Tomasz Kowalczyk (mitk) - Saturday, 24 October 2009, 23:15 GMT+2
Simply: You can add shuffled tracks to the end of dynamic playlist. Without this patch you can add tracks to the end of playlist, but not shuffled.
Comment by Jonathan Gordon (jdgordon) - Sunday, 25 October 2009, 03:22 GMT+2
looks good... I tihnk its missing stuff so it adds the tracks to the .playlist_control file though?
Comment by Tomasz Kowalczyk (mitk) - Sunday, 25 October 2009, 09:11 GMT+2
Yes, it adds also to .playlist_control. In fact it uses "playlist API" and is doing everything same way like other playlist manipulating commands.
Comment by Tomasz Kowalczyk (mitk) - Sunday, 25 October 2009, 10:58 GMT+2
Tested and ready to commit version. Diff against r23340.
   insert_last_shuffled.patch (5.8 KiB) 
 apps/playlist.c        |   15 ++++++++++++++-
 apps/playlist.h        |    6 +++++-
 apps/lang/english.lang |   28 ++++++++++++++++++++++++++++
 apps/onplay.c          |   25 ++++++++++++++++++++++++-
 4 files changed, 71 insertions(+), 3 deletions(-)

Comment by Tomasz Kowalczyk (mitk) - Wednesday, 28 October 2009, 11:54 GMT+2
Added patch to manual also.
   insert_last_shuffled.patch (6.7 KiB) 
 apps/playlist.c                        |   15 ++++++++++++++-
 apps/playlist.h                        |    6 +++++-
 apps/lang/english.lang                 |   28 ++++++++++++++++++++++++++++
 apps/onplay.c                          |   25 ++++++++++++++++++++++++-
 manual/working_with_playlists/main.tex |    6 +++++-
 5 files changed, 76 insertions(+), 4 deletions(-)

Comment by Tomasz Kowalczyk (mitk) - Wednesday, 28 October 2009, 14:31 GMT+2
There is no make sense to display insert_last_shuffled option when just one track is selected.
Also some comments added.
   insert_last_shuffled.patch (8.9 KiB) 
 apps/playlist.c                        |   40 ++++++++++++++++++++++-----------
 apps/playlist.h                        |    6 ++++
 apps/lang/english.lang                 |   28 +++++++++++++++++++++++
 apps/onplay.c                          |   25 +++++++++++++++++++-
 manual/working_with_playlists/main.tex |    6 ++++
 5 files changed, 89 insertions(+), 16 deletions(-)

Comment by Dave Hooper (stripwax) - Wednesday, 28 October 2009, 23:28 GMT+2
Committed!

Loading...