Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10733 - Touchscreen targets: software hold also locks touchscreen

Attached to Project: Rockbox
Opened by Yann Muller (jasio) - Wednesday, 28 October 2009, 22:12 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Wednesday, 28 October 2009, 22:36 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When the software lock is on, the touchscreen should be locked too. This is what this tiny patch does.

In action.c function get_action_worker() handles the lock by discarding the button events before they are processed. The same doesn't happen for touchscreen events because the code is placed before the lock handling.
I have moved the HAVE_TOUCHSCREEN section just after the HAS_BUTTON_HOLD section and the touchscreen actions are now blocked when the lock is active.
   softlock_touchscreen.patch (1.8 KiB) 
 apps/action.c |   41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Wednesday, 28 October 2009, 22:36 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks! In r23384.
Comment by Yann Muller (jasio) - Wednesday, 28 October 2009, 22:26 GMT+2
First patch added a space. Removed!
   softlock_touchscreen.patch (1.6 KiB) 
 apps/action.c |   39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

Loading...