Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10748 - rbutil: Explicitly override GUI layout direction setting for some widgets

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 31 October 2009, 13:32 GMT+2
Last edited by Tomer Shalev (tomers) - Saturday, 31 October 2009, 18:16 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch overrides layout direction settings of about and System Trace text browser widgets to Qt::LeftToRight.

This is done since both these browsers display latin text, and it doesn't look good when it is aligned to the right, as is the case if the utility language is set to Hebrew.
   rbutil_override_rtl.diff (0.9 KiB) 
 rbutilqt/systrace.cpp |    1 +
 rbutilqt/rbutilqt.cpp |    1 +
 2 files changed, 2 insertions(+)

This task depends upon

Closed by  Tomer Shalev (tomers)
Saturday, 31 October 2009, 18:16 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r23441
Comment by Dominik Wenger (Domonoky) - Saturday, 31 October 2009, 15:45 GMT+2
I think this patch is fine. And should just go in :-)
Comment by Dominik Riebeling (bluebrother) - Saturday, 31 October 2009, 15:56 GMT+2
According to the Qt documentation Qt should be able to figure the layout direction by itself. This leads me to the assumption that forcing the layout direction (in main.cpp) itself is a bad idea though I haven't figured why it doesn't work automatically. IMO we should figure what's going wrong here instead of adding special cases (of course, if it's completely broken in Qt it's ok but not-really-nice to add workarounds. However, we should understand why it doesn't behave as advertised).

As a quick workaround this patch obviously doesn't do any harm so isn't problematic.
Comment by Dominik Wenger (Domonoky) - Saturday, 31 October 2009, 16:10 GMT+2
The Qt Documentation isnt clear about this. For QApplication it says the LayoutDirection defaults to the language direction, and for QWidgets it says it defaults to LTR, so what is correct ?

So i think we have todo this Layoutdirection thing your self. (You can also see many Qt apps on the web which does this).
Comment by Tomer Shalev (tomers) - Saturday, 31 October 2009, 17:49 GMT+2
Force several more widgets into left-to-right layout
   rbutil_override_rtl.diff (3 KiB) 
 rbutil/rbutilqt/themesinstallwindow.cpp |    1 +
 rbutil/rbutilqt/rbutilqt.cpp            |    3 +++
 rbutil/rbutilqt/configure.cpp           |   11 +++++++++++
 rbutil/rbutilqt/systrace.cpp            |    1 +
 4 files changed, 16 insertions(+)

Loading...