Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10753 - skinable Recording screen statusbar

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Monday, 02 November 2009, 06:37 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 03 November 2009, 09:13 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As best as I can tell... this works on the sims... but it needs some testing on real targets..

load the "classic_statusbar.sbs" file for the custom statusbar and go into the recording screen.. the bar should agree with whats actually being recorded (The bitrate/encoder/samplerate shuold work.. the rec status and mono/stereo hasnt been rigged up yet).

I havnt (and cant) tested the samplerate for SPDIF recordings so someone needs to test that.


so test this you need to patch it (obviously :p ) and copy wps/classic_statusbar.sbs and wps/classic_statusbar/*.bmp into the .rockbox/wps folder on the target (create a class_statusbar folder under there for the bmps, the sbs goes along side the folder...) also put the attached bmps in that folder also....
   rec_skins.diff (9.7 KiB) 
 apps/gui/skin_engine/skin_parser.c |   10 ++
 apps/gui/skin_engine/skin_tokens.c |  162 +++++++++++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_tokens.h |    6 +
 wps/classic_statusbar.sbs          |   29 +++++-
 4 files changed, 200 insertions(+), 7 deletions(-)

   rec_encoders.bmp (1.8 KiB)
   rec_frequencies.bmp (2.2 KiB)
   rec_mpegbitrates.bmp (7.9 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 03 November 2009, 09:13 GMT+2
Reason for closing:  Accepted
Comment by Thomas Martitz (kugel.) - Monday, 02 November 2009, 17:52 GMT+2
you didn't add a WPS_TOKEN_HAVE_RECORDING case to check_feature_tags(), I assume you want to do that?
Comment by Jonathan Gordon (jdgordon) - Monday, 02 November 2009, 18:01 GMT+2
bah, yep, forgot that :)
Comment by Michael Chicoine (mc2739) - Tuesday, 03 November 2009, 03:24 GMT+2
Tested on e200v2, all formats, bitrates, and frequency displays look good. Stop, rec, pause icons look good. There is one icon to the right of the frequency indicator that is missing.

Loading...