Rockbox

Tasklist

FS#10783 - WPS translation

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 14 November 2009, 19:02 GMT
Last edited by Tomer Shalev (tomers) - Sunday, 15 November 2009, 21:40 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Following WPS translation support in r22837, I've changed the wps files to get common WPS phrases using the %Sx skin tag.

This patch also contains the changes done in " FS#10782  - WPS: Rename 'Next Song' to 'Next Track'"
This task depends upon

Closed by  Tomer Shalev (tomers)
Sunday, 15 November 2009, 21:40 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r23638.
Comment by Tomer Shalev (tomers) - Saturday, 14 November 2009, 20:02 GMT
This patch adds the followings:
- New conditional skin token 'Sr' which checks whether the currently loaded language is an RTL language (Hebrew/Arabic). It uses lang_is_rtl().
- The 'Sr' token is used across skin files to determine the location of colon, and the appropriate order of current track counter ('X of Y', or 'Y' of 'X').
- Added Hebrew translation
Comment by Tomer Shalev (tomers) - Saturday, 14 November 2009, 20:19 GMT
Synced to r23626
Comment by Jonathan Gordon (jdgordon) - Sunday, 15 November 2009, 01:40 GMT
looks good, but the 2nd hunk in skin_parser.c needs to be removed... that is only for features which are not compiled into that build... rtl is something which could change while the skin is loaded which would mean the skin wont work after a lang change,
Comment by Tomer Shalev (tomers) - Sunday, 15 November 2009, 20:51 GMT
Changes from previous patch:
- Fix jdgordon's remark
- Use colon in the translated string itself, in order to save usage of %Sr in many places

Loading...