Rockbox

Tasklist

FS#10796 - Clip - prevent power switch activation when coming out of hold

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Friday, 20 November 2009, 12:34 GMT
Last edited by Michael Chicoine (mc2739) - Saturday, 21 November 2009, 21:17 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch prevents power switch activation when coming out of hold by not allowing the power GPIO to be read until 1 second has passed since the hold switch has been released.
This task depends upon

Closed by  Michael Chicoine (mc2739)
Saturday, 21 November 2009, 21:17 GMT
Reason for closing:  Accepted
Additional comments about closing:  commited in r23686
Comment by Thomas Martitz (kugel.) - Friday, 20 November 2009, 20:47 GMT
Looks good, except that you seem to cause big breakage :) You need { } around the if (button_hold()), otherwise it will always return 0.
Comment by Michael Chicoine (mc2739) - Friday, 20 November 2009, 21:11 GMT
Thanks, here is the updated patch.
Comment by Rafaël Carré (funman) - Friday, 20 November 2009, 23:05 GMT
ok

Loading...