Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10796 - Clip - prevent power switch activation when coming out of hold

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Friday, 20 November 2009, 13:34 GMT+2
Last edited by Michael Chicoine (mc2739) - Saturday, 21 November 2009, 22:17 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch prevents power switch activation when coming out of hold by not allowing the power GPIO to be read until 1 second has passed since the hold switch has been released.
   button-clip.patch (1.1 KiB) 
 firmware/target/arm/as3525/sansa-clip/button-clip.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Michael Chicoine (mc2739)
Saturday, 21 November 2009, 22:17 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  commited in r23686
Comment by Thomas Martitz (kugel.) - Friday, 20 November 2009, 21:47 GMT+2
Looks good, except that you seem to cause big breakage :) You need { } around the if (button_hold()), otherwise it will always return 0.
Comment by Michael Chicoine (mc2739) - Friday, 20 November 2009, 22:11 GMT+2
Thanks, here is the updated patch.
   button-clip.patch (1.1 KiB) 
 firmware/target/arm/as3525/sansa-clip/button-clip.c |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comment by Rafaël Carré (funman) - Saturday, 21 November 2009, 00:05 GMT+2
ok

Loading...