Rockbox

Tasklist

FS#10833 - Protect against division by zero in AAC (mp4) codec

Attached to Project: Rockbox
Opened by Juliusz Chroboczek (jch) - Saturday, 05 December 2009, 18:52 GMT
Last edited by MichaelGiacomelli (saratoga) - Monday, 14 December 2009, 01:09 GMT
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This avoids a crash in the AAC codec. It's probably only fixing a symptom, not the actual bug, but it shouldn't do much harm not to crash in any case.

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Monday, 14 December 2009, 01:09 GMT
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r23983.
Comment by Juliusz Chroboczek (jch) - Saturday, 05 December 2009, 19:24 GMT
This is triggered by  FS#10832 .
Comment by Juliusz Chroboczek (jch) - Saturday, 05 December 2009, 23:40 GMT
In addition, it turns out that libfaad sometimes returns NULL without setting frame_info.error, which causes us to play garbage or crash. Check for this case.

Loading...