Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10855 - problems with statusbar skin (sbs)

Attached to Project: Rockbox
Opened by Teruaki Kawashima (teru) - Monday, 14 December 2009, 13:56 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Friday, 18 December 2009, 07:51 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type Gigabeat F/X
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Release 3.5
Due Date Undecided
Percent Complete 100%
Private No

Details

I noticed some redraw prblems using custom statusbar skin.

Target: Gigabeat X
Rockbxo version: r23989-091214

1. Right after exit text_editor plugin, list uses whole screen instead of sbs viewport.
2. If I keep pressing a button, sbs stops to update information.
e.g. if i keep pressing VOL UP buton, value of volume in sbs increases for a short period and then stops to increase.
And i release the button, the value jumps to correct value.
3. Informations are not update in setting menu unless press a button.
e.g. play any song and go to Setting -> Sound Settings -> Volume. current time in song is not updated.
there may be more screens that sbs is not updated unless press a button.

patch 01, 02 and 03 are fix for 1, 2 and 3 respectively.
also attached theme i used for testing.
   01_fix_list_vp_after_exit.patch (0.6 KiB) 
 apps/gui/viewport.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

   02_update_sbs_on_holding_button.patch (0.7 KiB) 
 apps/gui/statusbar-skinned.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

   03_update_sbs_in_setting_menu.patch (0.5 KiB) 
 apps/gui/option_select.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

   test.zip (5.4 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Friday, 18 December 2009, 07:51 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  got impatient and commited them myself :)
thanks
Comment by Jonathan Gordon (jdgordon) - Monday, 14 December 2009, 18:39 GMT+2
2 and 3 are fine... 1 looks wrong
Comment by Tomasz Kowalczyk (mitk) - Thursday, 17 December 2009, 12:53 GMT+2
I've got the 1st on Fuze with r24039

Loading...