Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10856 - Skip to previous track inconsistent when using cuesheet

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Tuesday, 15 December 2009, 15:11 GMT+2
Last edited by Michael Chicoine (mc2739) - Wednesday, 06 January 2010, 15:56 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To Michael Chicoine (mc2739)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Skipping to the previous track without cuesheet support enabled works as follows:
If track elapsed time is less than 3 seconds, skip to previous track
If track elapsed time is 3 seconds or more, skip to the start of current track

Skipping to the previous track with cuesheet support enabled currently works as follows:
If first segment elapsed time is less than 3 seconds, skip to previous track
If first segment elapsed time is 3 seconds or more, skip to the start of first segment
In any other segment after the first, skip to the start of the previous segment

This patch makes skip previous consistent on a track with cuesheet support. If skip previous is pressed in any segment before 3 seconds have elapsed, skip to the previous segment (or previous track if in the first segment). If skip previous is pressed in any segment with 3 or more seconds elapsed, skip to the start of the current segment.
   cuesheet-skip.patch (2.8 KiB) 
 apps/cuesheet.c |   16 ++++++++++++++--
 apps/cuesheet.h |    3 ++-
 apps/gui/wps.c  |    6 ++++--
 3 files changed, 20 insertions(+), 5 deletions(-)

This task depends upon

Closed by  Michael Chicoine (mc2739)
Wednesday, 06 January 2010, 15:56 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r24191
Comment by Jonathan Gordon (jdgordon) - Wednesday, 23 December 2009, 05:20 GMT+2
where is DEFAULT_SKIP_TRESH defined? I dont see any reason that needs to be passed into the skip function instead of used directly.
Comment by Michael Chicoine (mc2739) - Wednesday, 23 December 2009, 13:26 GMT+2
DEFAULT_SKIP_TRESH is defined in gui/wps.c (line 74).
Comment by Michael Chicoine (mc2739) - Wednesday, 23 December 2009, 16:59 GMT+2
Updated patch:

1. moved DEFAULT_SKIP_TRESH to gui/wps.h
2. added #include "gui/wps.h" in cuesheet.c
   cuesheet-skip-v2.patch (1.9 KiB) 
 apps/cuesheet.c |   14 +++++++++++++-
 apps/gui/wps.c  |    3 ---
 apps/gui/wps.h  |    3 +++
 3 files changed, 16 insertions(+), 4 deletions(-)

Loading...