Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10879 - Cabbie: Fix usage of spaces to position strings

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 26 December 2009, 22:16 GMT+2
Last edited by Tomer Shalev (tomers) - Monday, 28 December 2009, 21:10 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To Tomer Shalev (tomers)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Release 3.5
Due Date Undecided
Percent Complete 100%
Private No

Details

Following r24117:
http://svn.rockbox.org/viewvc.cgi?view=rev;revision=24117

This patch replaces usage of spaces to position playlist information strings (beneath the progress-bar) with specific x and width values taken from the progress bar itself.
I've modified only screens which used a viewport specifically for this line. Some other WPS screens don't, and I didn't modify them.

I would like to get some feedback from testers before committing.
   fix_wps_positioning.diff (2.5 KiB) 
 wps/cabbiev2.220x176x16.wps |    4 ++--
 wps/cabbiev2.138x110x2.wps  |    4 ++--
 wps/cabbiev2.160x128x2.wps  |    4 ++--
 wps/cabbiev2.160x128x16.wps |    4 ++--
 wps/cabbiev2.176x132x16.wps |    4 ++--
 wps/cabbiev2.128x128x16.wps |    5 ++---
 6 files changed, 12 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Tomer Shalev (tomers)
Monday, 28 December 2009, 21:10 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r24120

Loading...