Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10911 - Plugins: Fractals (formerly Mandelbrot)

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Wednesday, 13 January 2010, 20:07 GMT+2
Last edited by Tomer Shalev (tomers) - Friday, 15 January 2010, 06:53 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To Tomer Shalev (tomers)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch enhances the mandelbrot plugin (Plugins->Demo->mandelbrot) in the following ways:

- It lays the foundation to add additional fractals sets, other then just Mandelbrot.
- I has interruptible painting function, which allows browsing fractal during painting.
- It separates code parts into separate files, each with its own functionality

The patch is in working condition, but there is still some bug fixing and tweaking left to be done.

The code currently contains some debug printings (you will get warnings during compilation because of that).

I would like to get further comments (e.g. suggestion of different file naming) for other developers.
   fractals.diff (57.4 KiB) 
 apps/plugins/CATEGORIES                |    2 
 apps/plugins/SOURCES                   |    1 
 apps/plugins/fractals/cpu_coldfire.c   |   58 +++++
 apps/plugins/fractals/fractal_rect.h   |   38 +++
 apps/plugins/fractals/cpu_sh7043.c     |   94 ++++++++
 apps/plugins/fractals/SOURCES          |   10 
 apps/plugins/fractals/mandelbrot_set.c |  377 +++++++++++++++++++++++++++++++++
 apps/plugins/fractals/cpu_coldfire.h   |   29 ++
 apps/plugins/fractals/cpu_sh7043.h     |   29 ++
 apps/plugins/fractals/mandelbrot_set.h |   63 +++++
 apps/plugins/fractals/fractal.c        |  269 +++++++++++++++++++++++
 apps/plugins/fractals/fractal_sets.h   |   52 ++++
 apps/plugins/fractals/fractal.h        |  352 ++++++++++++++++++++++++++++++
 apps/plugins/fractals/cpu_arm.c        |   40 +++
 apps/plugins/fractals/fractal_rect.c   |  215 ++++++++++++++++++
 apps/plugins/fractals/fractals.make    |   21 +
 apps/plugins/fractals/cpu_arm.h        |   27 ++
 apps/plugins/SUBDIRS                   |    1 
 18 files changed, 1676 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Tomer Shalev (tomers)
Friday, 15 January 2010, 06:53 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r24230
Comment by Tomer Shalev (tomers) - Thursday, 14 January 2010, 23:58 GMT+2
Updated patch. Synched to r24228.

- Fixed many of the bugs
- Removed debug prints
- Removed idle loops that used to debug using the simulator
- Known bug: Empty line shows when scrolling left
   fractals.v2.diff (57 KiB) 
 apps/plugins/CATEGORIES                |    2 
 apps/plugins/SOURCES                   |    1 
 apps/plugins/fractals/cpu_coldfire.c   |   58 ++++
 apps/plugins/fractals/fractal_rect.h   |   38 +++
 apps/plugins/fractals/cpu_sh7043.c     |   94 +++++++
 apps/plugins/fractals/SOURCES          |   10 
 apps/plugins/fractals/mandelbrot_set.c |  396 +++++++++++++++++++++++++++++++++
 apps/plugins/fractals/cpu_coldfire.h   |   29 ++
 apps/plugins/fractals/cpu_sh7043.h     |   29 ++
 apps/plugins/fractals/mandelbrot_set.h |   63 +++++
 apps/plugins/fractals/fractal.c        |  260 +++++++++++++++++++++
 apps/plugins/fractals/fractal_sets.h   |   52 ++++
 apps/plugins/fractals/fractal.h        |  352 +++++++++++++++++++++++++++++
 apps/plugins/fractals/cpu_arm.c        |   40 +++
 apps/plugins/fractals/fractal_rect.c   |  208 +++++++++++++++++
 apps/plugins/fractals/fractals.make    |   21 +
 apps/plugins/fractals/cpu_arm.h        |   27 ++
 apps/plugins/SUBDIRS                   |    1 
 18 files changed, 1679 insertions(+), 2 deletions(-)

Comment by Tomer Shalev (tomers) - Friday, 15 January 2010, 06:48 GMT+2
- Fix all bugs I could find
- Update manual
- Tested on Cowon D2

This version is only for the record, as I am committing immediately after (following a short discussion in IRC).
   fractals.v3.diff (61.4 KiB) 
 apps/plugins/CATEGORIES                |    2 
 apps/plugins/SOURCES                   |    1 
 apps/plugins/fractals/cpu_coldfire.c   |   58 ++++
 apps/plugins/fractals/fractal_rect.h   |   38 +++
 apps/plugins/fractals/cpu_sh7043.c     |   94 +++++++
 apps/plugins/fractals/SOURCES          |   10 
 apps/plugins/fractals/mandelbrot_set.c |  392 +++++++++++++++++++++++++++++++++
 apps/plugins/fractals/cpu_coldfire.h   |   29 ++
 apps/plugins/fractals/cpu_sh7043.h     |   29 ++
 apps/plugins/fractals/mandelbrot_set.h |   60 +++++
 apps/plugins/fractals/fractal.c        |  260 +++++++++++++++++++++
 apps/plugins/fractals/fractal_sets.h   |   52 ++++
 apps/plugins/fractals/fractal.h        |  352 +++++++++++++++++++++++++++++
 apps/plugins/fractals/cpu_arm.c        |   40 +++
 apps/plugins/fractals/fractal_rect.c   |  209 +++++++++++++++++
 apps/plugins/fractals/fractals.make    |   21 +
 apps/plugins/fractals/cpu_arm.h        |   27 ++
 apps/plugins/SUBDIRS                   |    1 
 manual/plugins/mandelbrot.tex          |   81 ------
 manual/plugins/main.tex                |    4 
 manual/plugins/fractals.tex            |    2 
 21 files changed, 1676 insertions(+), 86 deletions(-)

Loading...