Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10925 - basic touchscreen support for virtual keyboard

Attached to Project: Rockbox
Opened by Teruaki Kawashima (teru) - Thursday, 21 January 2010, 05:16 GMT+2
Last edited by Teruaki Kawashima (teru) - Sunday, 27 June 2010, 16:09 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Cowon D2
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Johannes Schwarz pointed out that virtual keyboard lacks support for touchscreen. so i tried to add one.
but i don't actually understand how touchscreen works and don't have tagert to test on. so, feel free to improve, customize or even reject.
tocuh character to input a character.
tocuhing right side changes the page if there is more than one.
tocuh left/right side of edit line to move cursor left/right by one char.
morse input support is not added.
text on buttons is not localized.

probably this is not so usable especially for default keyboard with system font because of too small grid for character selection.
maybe it can be improved by defining something like MIN_GRID_SIZE and use it instead of font width or font height.
   vkeyboard-touchscreen.patch (4.7 KiB) 
 apps/recorder/keyboard.c |  110 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 110 insertions(+)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Sunday, 27 June 2010, 16:09 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r27156.
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 21 January 2010, 12:02 GMT+2
I've tested this on both sim & target (Onda VX747), works great!

It does need to be set with FONT_UI however to be useable on target, and you'll have to keep in mind that the sides of a touchscreen are much less responsive (at least, on the Onda that is) wrt the buttons.

I've attached a quick&dirty patch that sets the current font to FONT_UI, but I think in the long term we should have some kind of multifont support and can set different fonts for different contexts (list font, WPS font, keyboard font, etc..).
   vkeyboard-touchscreen_FONT_UI.diff (5.7 KiB) 
 b/apps/recorder/keyboard.c |  116 +++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 113 insertions(+), 3 deletions(-)

Comment by Teruaki Kawashima (teru) - Thursday, 21 January 2010, 12:46 GMT+2
Thank you for testing.
> you'll have to keep in mind that the sides of a touchscreen are much less responsive (at least, on the Onda that is) wrt the buttons.
it is good to know. but i realy want someone willing to improve this considering i don't have one to test on.

> It does need to be set with FONT_UI however to be useable on target,
how about my idea to define MIN_GRID_SIZE per target and use MAX(MIN_GRID_SIZE, font_h) or MAX(MIN_GRID_SIZE, font_w)? user font may not be large enough.
or is there anything bad other than the selector is too small?
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 21 January 2010, 13:54 GMT+2
>it is good to know. but i realy want someone willing to improve this considering i don't have one to test on.

Sure, I'm interested in doing that (will look at it later).

>how about my idea to define MIN_GRID_SIZE per target and use MAX(MIN_GRID_SIZE, font_h) or MAX(MIN_GRID_SIZE, font_w)? user font may not be large enough.

If it does what I think it does (setting a minimum size for each grid element) then it seems as a good idea.
Still I prefer to have multifont in the long term, but this solution is good enough for now.

>or is there anything bad other than the selector is too small?

I'm not sure what you mean with the selector being too small?
Comment by Teruaki Kawashima (teru) - Thursday, 21 January 2010, 14:21 GMT+2
> Still I prefer to have multifont in the long term, but this solution is good enough for now.
well, i didn't intend to be against this

i meant the selector = inverted part of vkeyboard to select which charactar to insert.
Comment by Teruaki Kawashima (teru) - Sunday, 24 January 2010, 14:21 GMT+2
* implemented my idea about MIN_GRID_SIZE.
* added morse code input support.
* always use ui fonts for buttons and chaged position of page flip button.
   vkeyboard-touchscreen.2.patch (8.3 KiB) 
 apps/recorder/keyboard.c |  176 ++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 167 insertions(+), 9 deletions(-)

Comment by Teruaki Kawashima (teru) - Sunday, 31 January 2010, 16:38 GMT+2
synched patch.
edit: remove unrelated change.

   keyboard-touchscreen.3.patch (7.9 KiB) 
 apps/recorder/keyboard.c |  166 +++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 161 insertions(+), 5 deletions(-)

Comment by Teruaki Kawashima (teru) - Sunday, 14 February 2010, 07:00 GMT+2
update patch.
   keyboard-touchscreen.4.patch (7.8 KiB) 
 apps/recorder/keyboard.c |  171 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 168 insertions(+), 3 deletions(-)

Comment by Teruaki Kawashima (teru) - Thursday, 24 June 2010, 15:25 GMT+2
synced.
   keyboard-touchscreen.5.patch (8 KiB) 
 apps/recorder/keyboard.c |  171 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 168 insertions(+), 3 deletions(-)

Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 24 June 2010, 16:37 GMT+2
Looks OK, you will need to add LANG_* tags for Ok, Delete and Cancel though.
Comment by Teruaki Kawashima (teru) - Saturday, 26 June 2010, 15:08 GMT+2
update
* add LANG strings.
* enlarge bottom buttons.
   keyboard-touchscreen.6.patch (9.2 KiB) 
 apps/recorder/keyboard.c |  171 ++++++++++++++++++++++++++++++++++++++++++++++-
 apps/lang/english.lang   |   51 ++++++++++++++
 2 files changed, 219 insertions(+), 3 deletions(-)

Comment by Maurus Cuelenaere (mcuelenaere) - Saturday, 26 June 2010, 16:28 GMT+2
I think this can go in.

Teruaki, you have commit rights, don't you?

Loading...