Rockbox

Tasklist

FS#10939 - Fix car mode on Sansa AMS players

Attached to Project: Rockbox
Opened by Jeff Siddall (jsiddall) - Saturday, 30 January 2010, 02:03 GMT
Last edited by Rafaël Carré (funman) - Thursday, 04 March 2010, 19:31 GMT
Task Type Patches
Category Bootloader
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Rbutil SVN
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Here's a patch that causes mkamsboot to load OF only if a button is pressed. RB is loaded by default when USB is connected. This is important for car mode to work, but it may not be the right behavior for everyone since the RB USB stack cannot be used to transfer files.

The patch essentially causes mkamsboot to build the bootloader in such a way that it no longer checks for the presence of a USB connection at bootup, thus does not try to start OF if USB is connected.

/rockbox/rbutil/mkamsboot/dualboot/dualboot.S

86a87
> /* Removed so that only pressing the button will force OF
93a95
> */
This task depends upon

Closed by  Rafaël Carré (funman)
Thursday, 04 March 2010, 19:31 GMT
Reason for closing:  Rejected
Additional comments about closing:  Booting OF if an USB connection is detected is important if for some reason the code which checks button press doesn't work.

For example it could work on 10 devices but not on another, especially on models where we don't read buttons the same way than the OF.

So I am rejecting the patch now, we will need to look at it when an USB driver is implemented (the presence of USB in the bootloader could help prevent bricking)
Comment by Jeff Siddall (jsiddall) - Saturday, 30 January 2010, 02:09 GMT
Attached as a proper patch

Loading...