Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10943 - Optimized replacements for libgcc dividers, clz on ARM.

Attached to Project: Rockbox
Opened by Andrew Mahone (Unhelpful) - Saturday, 30 January 2010, 10:25 GMT+2
Last edited by Andrew Mahone (Unhelpful) - Monday, 01 February 2010, 02:37 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch aims to replace libgcc's signed and unsigned 32-bit division functions on ARM with faster (and on ARMv5+, also smaller) functions. CLZ is also replaced on ARMv4. Binsize increases about 300B on ARMv4, decreases about 600B on ARMv5+. Deltas will be better with EABI, which uses a div and a divmod support funtion, as divmod performs well enough for div to be aliased to it. The functions are included in libfirmware, libplugin, and libcodec, causing them to replace libgcc functions. As the new divider is the same as the one used by the APE codec on ARMv5+, APE no longer uses a specialized divider on these targets unless iram is used.
   arm_libgcc_replacement.20100130041132.patch (23.4 KiB) 
 b/apps/codecs/lib/SOURCES           |    1 
 b/apps/codecs/lib/clz_arm.S         |   19 
 b/apps/codecs/lib/codeclib.h        |    2 
 b/apps/plugins/lib/SOURCES          |    1 
 b/firmware/SOURCES                  |    1 
 b/firmware/target/arm/support-arm.S |  699 ++++++++++++++++++++++++++++++++++++
 6 files changed, 722 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Andrew Mahone (Unhelpful)
Monday, 01 February 2010, 02:37 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r24432.

Loading...