Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11009 - Include dualboot.h in dualboot.c as an additional compiletime sanity check

Attached to Project: Rockbox
Opened by Tobias Diedrich (ranma) - Saturday, 13 February 2010, 16:22 GMT+2
Last edited by Bertrik Sikken (bertrik) - Saturday, 13 February 2010, 20:02 GMT+2
Task Type Patches
Category Bootloader
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Rbutil SVN
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This small patch prevents you from bricking your player if you forget to update dualboot.h in addition to dualboot.c.
Without the patch a mismatch dualboot.c/dualboot.h combination compiles, but of course the patcher then copies the wrong size.
With the patch you get a compiler error due to type mismatch:

CC dualboot.c
dualboot.c:63: error: conflicting types for ‘dualboot_c200v2’
dualboot.h:6: error: previous declaration of ‘dualboot_c200v2’ was here
make: *** [build/dualboot.o] Error 1

http://forums.rockbox.org/index.php?topic=14064.msg162128#msg162128
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Saturday, 13 February 2010, 20:02 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as SVN r24636, thanks.
Comment by Tobias Diedrich (ranma) - Saturday, 13 February 2010, 16:25 GMT+2
Hmm, somehow the file attach didn't seem to work?
   mkamsboot_bin2c.patch (0.4 KiB) 
 rbutil/mkamsboot/dualboot/bin2c.c |    1 +
 1 file changed, 1 insertion(+)

Loading...