Rockbox

Tasklist

FS#11009 - Include dualboot.h in dualboot.c as an additional compiletime sanity check

Attached to Project: Rockbox
Opened by Tobias Diedrich (ranma) - Saturday, 13 February 2010, 15:22 GMT
Last edited by Bertrik Sikken (bertrik) - Saturday, 13 February 2010, 19:02 GMT
Task Type Patches
Category Bootloader
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Rbutil SVN
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This small patch prevents you from bricking your player if you forget to update dualboot.h in addition to dualboot.c.
Without the patch a mismatch dualboot.c/dualboot.h combination compiles, but of course the patcher then copies the wrong size.
With the patch you get a compiler error due to type mismatch:

CC dualboot.c
dualboot.c:63: error: conflicting types for ‘dualboot_c200v2’
dualboot.h:6: error: previous declaration of ‘dualboot_c200v2’ was here
make: *** [build/dualboot.o] Error 1

http://forums.rockbox.org/index.php?topic=14064.msg162128#msg162128
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Saturday, 13 February 2010, 19:02 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed as SVN r24636, thanks.
Comment by Tobias Diedrich (ranma) - Saturday, 13 February 2010, 15:25 GMT
Hmm, somehow the file attach didn't seem to work?

Loading...