This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11027 - Support for "Pebbles", small visualisation plugins that get loaded into the skin buffer
Attached to Project:
Rockbox
Opened by Frank Gevaerts (fg) - Tuesday, 16 February 2010, 21:51 GMT+2
Last edited by Frank Gevaerts (fg) - Sunday, 31 July 2011, 14:39 GMT+2
Opened by Frank Gevaerts (fg) - Tuesday, 16 February 2010, 21:51 GMT+2
Last edited by Frank Gevaerts (fg) - Sunday, 31 July 2011, 14:39 GMT+2
|
DetailsPreliminary patch to explore the concept of plugins that consist of a single function ("pebbles", small rocks) to avoid the need for relocation.
These plugins are loaded into the skin buffer, and are called during WPS redraw. Add a %P token to the wps to try the included test_pebble Still to do: - actually parse the token to allow specifying the pebble to load - call the pebble for init/exit - implement bookkeeping and clearing of the pebble table on wps reload - work out how the pebble-allocated memory should work - test on non-ARM - check the plugin API version on load - allocate the correct buffer size 
pebbles_v1.diff
(14.4 KiB)
tools/buildzip.pl | 2 tools/root.make | 7 ++ apps/pebble.h | 35 ++++++++++++ apps/gui/skin_engine/skin_parser.c | 16 +++++ apps/gui/skin_engine/skin_display.c | 10 +++ apps/gui/skin_engine/skin_tokens.h | 2 apps/pebbles/SOURCES | 1 apps/pebbles/pebbles.make | 61 ++++++++++++++++++++++ apps/pebbles/test_pebble.c | 29 ++++++++++ apps/pebbles/pebble.lds | 55 ++++++++++++++++++++ apps/plugin.c | 2 apps/SOURCES | 1 apps/pebble.c | 97 ++++++++++++++++++++++++++++++++++++ 13 files changed, 315 insertions(+), 3 deletions(-) |
This task depends upon
Closed by Frank Gevaerts (fg)
Sunday, 31 July 2011, 14:39 GMT+2
Reason for closing: Rejected
Additional comments about closing: Not a viable way of doing this
Sunday, 31 July 2011, 14:39 GMT+2
Reason for closing: Rejected
Additional comments about closing: Not a viable way of doing this
some random thoughts:
the/a pebble api needs to give the pebble some internal function pointers. get_*_token_value() and just get_token() so it can easily get the value from any other token
likewise it should be able to act like a simple token so it can just return the string to display
also access to the skin_buffer_alloc() function, and the entry point should be called for the parse line and updates
it should keep track of the update requirements for the token (WPS_REFRESH_DYNAMIC|STATIC|etc)
Also, it would be good to be able to reuse the same pebble more than once, either between skins, or even in the same skin (look at skin fonts and backdrops)
The included test pebble is a bit more interesting now, and pebbles are built unconditionally, so there are no more changes needed to configure
Re-using a pebble shouldn't be too hard, and adding a pebble_api is easy.
Use with %P|name_of_pebble| (e.g. "%P|test_pebble|"), the pebble will get the entire enclosing viewport.
I've added a starfield pebble, but that one doesn't work properly. It suffers from illegal instructions, data aborts and the like. Help in figuring out why is welcome.
It doesn't work on coldfire right now. Investigating.
The wps I use for testing is:
%wd
%V|10|10|73|73|1|ffffff|000000|
%P|test_pebble|
%V|93|10|73|73|1|ff0000|00ff00|
%P|test_pebble|
%V|10|103|156|107|1|ffffff|000000|
%P|starfield|
- partly works on m68k (test_pebble works for me, starfield does not). Linker scripts and compilers are evil!
- passes the viewport using a global (similar to rb) named pebble_vp
- calls lcd_set_viewport before calling the pebble paint function to ensure that the correct viewport is active
Testers on SH and MIPS are welcome, as well as people who can fix the m68k issues