FS#11046 : Quickscreen WPS icons

Status Closed
Percent Complete
100%
Task Type Patches
Category User Interface
Assigned To

tomers
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by tomers - 2010-02-21
Last edited by jdgordon - 2010-03-14

FS#11046 - Quickscreen WPS icons

In this patch, WPS icons for Shuffle and Repeat are shown beneath the corresponding text labels.

The patch is a work in progress and is likely to fails on targets with smaller screens, such as the attached clip screenshot. There are way too many end cases in quickscreen_fix_viewports()… This patch was tested on the default Cabbie theme. It currently doesn’t handle well the case of really large icons, etc.

The patch still holds some limitation, such as support for icons only for Shuffle and Repeat (it could be made more generic), and only for the left and right Quickscreen items (not the top and bottom items).

I would like to get more comments and suggestions.
This patch could raise a discussion on whether we can use a wps file for the Quickscreen or not, etc…

quickscreen_wps_icons.diff (19.7 KiB)

qs_wps_icons_cowond2.png (157.6 KiB)

qs_wps_icons_ipod1g2g.png (41.1 KiB)

qs_wps_icons_sansae200.png (50.2 KiB)

qs_wps_icons_sansaclip.png (75.1 KiB)

Closed by jdgordon
2010-03-14 12:18
Reason for closing: Rejected