Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11047 - Simplify keyboard code

Attached to Project: Rockbox
Opened by Fred Bauer (freddyb) - Monday, 22 February 2010, 05:43 GMT+2
Last edited by Teruaki Kawashima (teru) - Thursday, 25 February 2010, 08:11 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes no functional changes but simplifies the code by putting each user action into a separate function making the code more maintainable and allowing reuse of code in the future.
   keyboard.c (34 KiB)
   simple_keyboard-v1.diff (21.4 KiB) 
 apps/recorder/keyboard.c |  677 +++++++++++++++++++++++++++--------------------
 1 file changed, 390 insertions(+), 287 deletions(-)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Thursday, 25 February 2010, 08:11 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Commited partially with some changes.
Comment by Teruaki Kawashima (teru) - Monday, 22 February 2010, 09:10 GMT+2
i don't like this so much. i think it adds too many function. also it increase ram usage by ~280 bytes.
Comment by Fred Bauer (freddyb) - Monday, 22 February 2010, 18:04 GMT+2
Are you joking?

Loading...