Rockbox

Tasklist

FS#11066 - Fix running time screen to work on targets with software USB

Attached to Project: Rockbox
Opened by MichaelGiacomelli (saratoga) - Saturday, 27 February 2010, 21:35 GMT
Last edited by MichaelGiacomelli (saratoga) - Saturday, 27 February 2010, 23:09 GMT
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Currently on PP, AMS, and probably others the "Running Time" screen doesn't actually get reset when rockbox is charged. The only way it'll actually get reset that I can find is if the user inserts a charger while the running screen is open or the nvram is cleared.

This patch changes default_event_handler_ex to reset the running time on USB_DISCONNECT or CHARGER_DISCONNECT events.
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Saturday, 27 February 2010, 23:09 GMT
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r24954.
Comment by Frank Gevaerts (fg) - Saturday, 27 February 2010, 21:45 GMT
- Not all players charge over USB, so USB disconnect does not necessarily mean end of charging
- not all code necessarily uses default_event_handler_ex()
- The USB disconnect event actually means MSC disconnect. If you charge without MSC, (by holding the appropriate button while connecting), this won't trigger

In general, I think this is really the wrong place to handle this
Comment by MichaelGiacomelli (saratoga) - Saturday, 27 February 2010, 22:19 GMT
Updated patch following discussion here: http://www.rockbox.org/irc/log-20100227#22:34:27

The new patch moves MSC mode detection to usb_screen.c in order to hopefully miss fewer events.
Comment by MichaelGiacomelli (saratoga) - Saturday, 27 February 2010, 22:27 GMT
Remove needless statement.

Loading...