Rockbox

Tasklist

FS#11096 - %Tl: Set the last touch time intially to 0

Attached to Project: Rockbox
Opened by Jens Theeß (punkt) - Friday, 12 March 2010, 21:39 GMT
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 15 June 2010, 06:55 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

As it is now, last_touchscreen_touch is initialized to 0xffff, which is in the future. Therefore %Tl is true at rockbox start, and doesn't turn to false after the timeout of %Tl elapsed. This seems wrong, since the user hasn't actually touched yet.

With the proposed patch, %Tl is also true at rockbox start, but turns to false after the timeout elapses.

I thought of initializing last_touchscreen_touch to INT_MIN, but that didn't work for some reason.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 15 June 2010, 06:55 GMT
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Wednesday, 24 March 2010, 10:05 GMT
does this fix the problem? I tried in the sim and got nowhere
Comment by Jens Theeß (punkt) - Saturday, 27 March 2010, 14:06 GMT
That fix works for me in the sim.

Loading...