Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11099 - Add a "Resume Overlap" playback setting

Attached to Project: Rockbox
Opened by Magnus Holmgren (learman) - Saturday, 13 March 2010, 11:19 GMT+2
Last edited by Magnus Holmgren (learman) - Saturday, 24 April 2010, 16:45 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To Magnus Holmgren (learman)
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Add a "Resume Overlap" playback setting, so that when resuming playback, it can start a short while earlier in the track (up to 60 seconds).

Not implemented for hwcodec yet (it may be trickier there).
   overlap.diff (3.5 KiB) 
 apps/lang/english.lang                        |   17 +++++++++++++++++
 apps/settings.h                               |    3 +++
 apps/menus/playback_menu.c                    |    5 +++++
 apps/settings_list.c                          |    6 ++++++
 apps/playback.c                               |   11 +++++++++++
 manual/configure_rockbox/playback_options.tex |    7 +++++++
 6 files changed, 49 insertions(+)

This task depends upon

Closed by  Magnus Holmgren (learman)
Saturday, 24 April 2010, 16:45 GMT+2
Reason for closing:  Accepted
Comment by Nils Wallménius (nls) - Friday, 19 March 2010, 12:48 GMT+2
I like this feature and think may users will as well, however i find the "Resume Overlap" name unobvious.
How about "Rewind before resume" or something similar?
Comment by Magnus Holmgren (learman) - Saturday, 20 March 2010, 16:37 GMT+2
Yes, that's a better name.
   resume_rewind.diff (3.8 KiB) 
 apps/lang/english.lang                        |   17 +++++++++++++++++
 apps/settings.h                               |    3 +++
 apps/menus/playback_menu.c                    |    5 +++++
 apps/settings_list.c                          |    6 ++++++
 apps/playback.c                               |   13 +++++++++++++
 manual/configure_rockbox/playback_options.tex |    9 +++++++++
 6 files changed, 53 insertions(+)

Comment by Alexander Levin (fml2) - Tuesday, 06 April 2010, 22:33 GMT+2
IMO the new variable should be commented -- what it means, in what units it's measured etc. Otherwise one has to dig through the code to find it out.

Loading...