- Status Closed
- Percent Complete
- Task Type Patches
- Category Drivers
-
Assigned To
pamaury - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#11118 - Reduce the number of cached sector in the fat driver
This patch reduces the number of cached sector in the fat_dir structure because it's useless.
It requires a nearly complete rewrite of fat_getnext.
At the same time, I made it check more things about LFN entries:
* last long entry attribute in the first entry
* ordinal are all present and decreasing
I could also implement checkuming but I I fear that not all fat drivers implement it.
Please review and test it !
Closed by pamaury
2010-03-22 10:48
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2010-03-22 10:48
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
r25290
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Amaury, I have tested it on my Nano2G and Sansa Fuze and I have no noticeable differences.
Rockbox starts fine, playing music and a random selection of plugins work.
New patch, mostly cosmetics.
But why is it useless? A cache ought to be useful for HD-based targets, even if it is useless for flash-based targets…
Only the most recently read sector in the cache is ever reused (the structure of FAT directories guarantees it). Keeping the other two sectors around has *zero* benefit, on any target.
New patch. I fixed a potential buffer overflow and several other things :)
I tested it to the limit and it works correctly.