Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11131 - add handler for audio irq

Attached to Project: Rockbox
Opened by Tobias Diedrich (ranma) - Friday, 19 March 2010, 20:33 GMT+2
Last edited by Tobias Diedrich (ranma) - Tuesday, 23 March 2010, 10:06 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To Tobias Diedrich (ranma)
Player Type Sansa c200
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Enable and handle the audio irq (interrupt 9).
This is used for various audio-unrelated tasks and generates interrupts on:
usb plug/unplug
charger enable/disable
charger finished
realtime clock irq (once per second or once per minute)
adc conversion finished (the old adc code was not waiting for the conversion to finish!?)

It converts the adc code and usb code to use this, this could be extended to the charging code.
   audio_irq.patch (13.6 KiB) 
 rockbox-irqwork/firmware/target/arm/as3525/system-as3525.c  |    1 
 rockbox-irqwork/firmware/target/arm/as3525/usb-as3525.c     |   22 +-
 rockbox-irqwork/firmware/target/arm/as3525/audio-as3525.c   |  105 ++++++++++++
 rockbox-irqwork/firmware/target/arm/as3525/power-as3525.c   |    2 
 rockbox-irqwork/firmware/target/arm/adc-as3514.c            |    3 
 rockbox-irqwork/firmware/export/as3514.h                    |   15 +
 rockbox-irqwork/firmware/target/arm/ascodec-target.h        |   10 +
 rockbox-irqwork/firmware/target/arm/powermgmt-ascodec.c     |    8 
 rockbox-irqwork/firmware/target/arm/as3525/usb-target.h     |   29 +++
 rockbox-irqwork/firmware/target/arm/as3525/ascodec-target.h |   10 +
 rockbox-irqwork/firmware/target/arm/as3525/ascodec-as3525.c |   13 +
 rockbox-irqwork/firmware/target/arm/as3525/audio-target.h   |   28 +++
 12 files changed, 231 insertions(+), 15 deletions(-)

This task depends upon

Closed by  Tobias Diedrich (ranma)
Tuesday, 23 March 2010, 10:06 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed
Comment by Tobias Diedrich (ranma) - Friday, 19 March 2010, 20:34 GMT+2
Depends on http://www.rockbox.org/tracker/task/11130
Comment by Tobias Diedrich (ranma) - Friday, 19 March 2010, 22:06 GMT+2
Updated for newer 11130 and cleaned up a lot more.
   audio_irq.patch (13.3 KiB) 
 rockbox-irqwork/firmware/target/arm/as3525/system-as3525.c  |    1 
 rockbox-irqwork/firmware/target/arm/as3525/usb-as3525.c     |   22 +-
 rockbox-irqwork/firmware/target/arm/as3525/power-as3525.c   |    1 
 rockbox-irqwork/firmware/target/arm/adc-as3514.c            |   12 +
 rockbox-irqwork/firmware/export/as3514.h                    |   15 +
 rockbox-irqwork/firmware/target/arm/ascodec-target.h        |   22 ++
 rockbox-irqwork/firmware/target/arm/powermgmt-ascodec.c     |    8 
 rockbox-irqwork/firmware/target/arm/as3525/usb-target.h     |   29 +++
 rockbox-irqwork/firmware/target/arm/as3525/ascodec-target.h |    8 
 rockbox-irqwork/firmware/target/arm/as3525/ascodec-as3525.c |  116 +++++++++++-
 10 files changed, 219 insertions(+), 15 deletions(-)

Comment by Rafaël Carré (funman) - Saturday, 20 March 2010, 16:41 GMT+2
Tested on Clip+ with  FS#11130 : OK
Comment by Michael Chicoine (mc2739) - Saturday, 20 March 2010, 23:17 GMT+2
Tested on e260v2 with r25262 and  FS#11130 :

All functions appear normal (except as noted in  FS#11130 ).
Comment by Michael Chicoine (mc2739) - Monday, 22 March 2010, 12:32 GMT+2
Tested with the latest patch on  FS#11130 : no problems noted

Loading...