Rockbox

Tasklist

FS#11143 - buffering thread debug showing remote

Attached to Project: Rockbox
Opened by Ronald Malbosc (Chiyo-chan) - Wednesday, 24 March 2010, 21:11 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 25 April 2010, 12:01 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Hi,

To help me diagnotics my buffring problem, I added remote output to the buffering thread debug (added lcd_remote_puts juste before every lcd_puts on the right part of debug_menu.c).
I've added a patch to the current svn file.
As it's my first patch, let me know is anything isn't right.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 25 April 2010, 12:01 GMT
Reason for closing:  Fixed
Additional comments about closing:  done useing the correct API in r25712.
Comment by Rafaël Carré (funman) - Wednesday, 31 March 2010, 09:17 GMT
Did you try to build on a target without remote ?
Comment by Ronald Malbosc (Chiyo-chan) - Wednesday, 31 March 2010, 09:56 GMT
Nope, I didn't try that.
Comment by Ronald Malbosc (Chiyo-chan) - Wednesday, 31 March 2010, 16:49 GMT
Just tried.
Effectively problem during compile for a target without a LCD remote (tried iPod Video).
I've attached a new version of the patch which include correct (I think ^^) #ifdef.

Loading...