Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11171 - Make question and confirmation of hotkey assignment better localizable

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Saturday, 03 April 2010, 21:29 GMT+2
Last edited by Alexander Levin (fml2) - Saturday, 03 April 2010, 23:04 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The current code constructs the question whether the hotkey should be assigned from the confirmation by just appending a quotation mark (i.e. "Set xyz" -> "Set xyz?") This doesn't work for all languages.

The patch changes it so that it's better localizable.
   hotkey_assignment.diff (2.5 KiB) 
 apps/lang/english.lang |   25 +++++++++++++++++++++----
 apps/onplay.c          |   20 ++++++++------------
 2 files changed, 29 insertions(+), 16 deletions(-)

This task depends upon

Closed by  Alexander Levin (fml2)
Saturday, 03 April 2010, 23:04 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Cmmitted as r25457
Comment by Alexander Levin (fml2) - Saturday, 03 April 2010, 22:18 GMT+2
Improved the patch: yesno screen already displays the confirmation, so we don't need to show the splash.
   hotkey_assignment2.diff (2.3 KiB) 
 apps/lang/english.lang |   25 +++++++++++++++++++++----
 apps/onplay.c          |   11 +++++------
 2 files changed, 26 insertions(+), 10 deletions(-)

Loading...