Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11175 - A theme can confuse the playback system

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Monday, 05 April 2010, 17:44 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 13 October 2010, 13:12 GMT+2
Task Type Bugs
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Using the CenterArt v2.0 theme (http://themes.rockbox.org/index.php?themeid=485&target=ipodvideo) can seriously confuse the playback system.

When the WPS from that theme is used (sbs and the rest of the config are not needed), selecting the first file in a directory starts playback of that directory, but often not of the first file.
If you then switch to the cabbiev2 wps while playback is active, the rebuffer (due to AA differences) will result in the correct track being played.

This is with default settings (apart from the theme obviously). It happens both from the file browser and the database.

Reproduceable on ipod video by both me and yorick (http://www.rockbox.org/irc/log-20100405#14:56:55 and further)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 13 October 2010, 13:12 GMT+2
Reason for closing:  Fixed
Comment by Jonathan Gordon (jdgordon) - Tuesday, 13 April 2010, 12:30 GMT+2
this patch *might* fix it...but i doubt it. try it anyway please
   buffering.diff (3.1 KiB) 
 apps/gui/skin_engine/skin_display.c |    5 +++--
 apps/playback.c                     |   18 ++++++++++++++++++
 apps/buffering.c                    |   13 +++++++++++++
 apps/buffering.h                    |    2 ++
 4 files changed, 36 insertions(+), 2 deletions(-)

Comment by Frank Gevaerts (fg) - Wednesday, 14 April 2010, 21:01 GMT+2
This doesn't fix it.

It looks like it's unrelated with how full the buffer is. I've seen it with both a directory with 4 ogg files at 8MB total and 100MB flacs
Comment by Frank Gevaerts (fg) - Wednesday, 14 April 2010, 21:23 GMT+2
Removing the last line of the wps (The %Vp tag) makes the problem go away
Comment by Frank Gevaerts (fg) - Wednesday, 14 April 2010, 22:21 GMT+2
A wps with only "%Vp|0|%pp - %it|%pp - %fn|" is enough for me to reproduce the problem
Comment by Frank Gevaerts (fg) - Wednesday, 14 April 2010, 22:59 GMT+2
If I select a wps with just "%Vp|0|%fn|" in it on my ipod video, I get a data abort now, at 00034344, which is in wps_parse.
Comment by Jonathan Gordon (jdgordon) - Thursday, 15 April 2010, 03:24 GMT+2
add another | at the end and it wont data abort.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 27 April 2010, 10:10 GMT+2
CRAP! I hate this answer but it looks like it is related to broken files!
now why the hell is the theme showing the bug though?
Comment by UltraMagnus001 (ultramagnus0001) - Tuesday, 15 June 2010, 17:07 GMT+2
I had the same problem, but now with the latest build r26857 no themes works on the now playing screen!
Comment by Justin Hannigan (Chronon) - Wednesday, 28 July 2010, 21:32 GMT+2
From http://forums.rockbox.org/index.php?topic=25365.0
This is for a Gigabeat F40 running Rockbox 3.6

Using the zeroclutter theme I created a playlist containing one album with 12 tracks (APC's Thirteenth Step). I started playback and let the first track (The Package) play for about 15 seconds. Then I shut down the player and booted again. I selected Resume Playback from the main menu and it resumed playing track 3 instead, this time showing the observed repetition of the current track two positions later in the playlist. Strangely, while still playing track 3 (The Noose) I changed themes to cabbie v2 causing a rebuffer. Strangely, it rebuffered the correct track (The Package).

Some of the behavior seems to depend on the state of the buffer. I let it play for 45 seconds under the same circumstances and this time it resumed in the correct place but listed the next track as a duplicate of the 12th track instead of correctly as the 2nd. During playback of the spurious duplicate changing the theme to cabbie v2 once again caused Rockbox to rebuffer the correct track (Track #2).

Comment by Magnus Holmgren (learman) - Wednesday, 11 August 2010, 21:02 GMT+2
Should be fixed in r27773.

Loading...