This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11195 - Remove redundant lang_id from the hotkey items
Attached to Project:
Rockbox
Opened by Alexander Levin (fml2) - Sunday, 11 April 2010, 00:47 GMT+2
Last edited by Jeffrey Goode (Blue_Dude) - Sunday, 11 April 2010, 02:47 GMT+2
Opened by Alexander Levin (fml2) - Sunday, 11 April 2010, 00:47 GMT+2
Last edited by Jeffrey Goode (Blue_Dude) - Sunday, 11 April 2010, 02:47 GMT+2
|
DetailsThe hotkey items have the lang_id's although the menus already have them. The patch eliminates the redundancy. This should also slightly reduce the bin size, but the main purpose of the patch is to get rid of the redundancy (the lang_id in the hotkey item has to match the lang_id in the menu).
The hotkey items must point to MENUITEM_FUNCTION now, which is the case for all hotkeyable items now. 
hotkey_langid.diff
(2.8 KiB)
apps/onplay.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) |
This task depends upon
Closed by Jeffrey Goode (Blue_Dude)
Sunday, 11 April 2010, 02:47 GMT+2
Reason for closing: Accepted
Additional comments about closing: Lovely! Committed in r25581
Sunday, 11 April 2010, 02:47 GMT+2
Reason for closing: Accepted
Additional comments about closing: Lovely! Committed in r25581