Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11250 - Set hotkeys from a normal menu, not with a key in the context menu

Attached to Project: Rockbox
Opened by Jeffrey Goode (Blue_Dude) - Saturday, 08 May 2010, 04:17 GMT+2
Last edited by Jeffrey Goode (Blue_Dude) - Sunday, 09 May 2010, 04:12 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This removes hotkey setting in the context menu and adds menu items for setting. The reset screen is gone, the view hotkeys screen is gone. The yesno dialog is gone. All that's left is two menus, one for wps and one for tree. I figured out a way to change the settings_list to only show the appropriate options, so that behaves.

The hotkey assignments are unchanged. The hotkey behavior is unchanged. Only the method of assigning them has changed.
   hotkey_menu.patch (18.7 KiB) 
 apps/lang/slovak.lang      |   24 +++++-----
 apps/lang/english.lang     |   38 ++++++++--------
 apps/lang/italiano.lang    |   36 ++++++++--------
 apps/onplay.c              |  101 +++++----------------------------------------
 apps/menu.c                |   22 ---------
 apps/settings.h            |    2 
 apps/menus/settings_menu.c |   45 +-------------------
 apps/onplay.h              |   12 ++++-
 apps/settings_list.c       |   49 ++++++++++++---------
 9 files changed, 107 insertions(+), 222 deletions(-)

This task depends upon

Closed by  Jeffrey Goode (Blue_Dude)
Sunday, 09 May 2010, 04:12 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r25905
Comment by Alexander Levin (fml2) - Saturday, 08 May 2010, 09:45 GMT+2
I like it! WHat about adding the item "Turn the backlight on"? This would be a "do nothing" function that would only make the backlight go on -- without the splash "hotkey not set".
Comment by Jeffrey Goode (Blue_Dude) - Saturday, 08 May 2010, 20:09 GMT+2
More cleanup, includes manual updates. Syncs with recent lang updates. Hotkey is now ignored if no assignment is set, instead of displaying a splash.

I haven't tried it yet, but I'll bet just turning the hotkey off will bring up the backlight upon a hotkey press without doing anything else.


   hotkey-menu2.patch (36.6 KiB) 
 apps/tree.c                                       |    5 
 apps/lang/slovak.lang                             |   86 +--------------
 apps/lang/english.lang                            |   50 ++++-----
 apps/lang/czech.lang                              |   83 +--------------
 apps/lang/italiano.lang                           |   84 +--------------
 apps/onplay.c                                     |  121 +++-------------------
 apps/gui/wps.c                                    |    5 
 apps/menu.c                                       |   22 ----
 apps/settings.h                                   |    2 
 apps/menus/settings_menu.c                        |   45 --------
 apps/menus/playlist_menu.c                        |    2 
 apps/onplay.h                                     |   12 ++
 apps/menu.h                                       |    1 
 apps/settings_list.c                              |   49 +++++---
 apps/root_menu.h                                  |    1 
 manual/working_with_playlists/main.tex            |    1 
 manual/rockbox_interface/hotkeys.tex              |   32 ++---
 manual/rockbox_interface/wps.tex                  |   12 --
 manual/rockbox_interface/browsing_and_playing.tex |   10 -
 manual/appendix/config_file_options.tex           |    6 +
 manual/configure_rockbox/hotkey_settings.tex      |   13 --
 21 files changed, 156 insertions(+), 486 deletions(-)

Comment by Jeffrey Goode (Blue_Dude) - Saturday, 08 May 2010, 20:36 GMT+2
Use these lang files instead. I don't think I deprecated the other ones nicely.
   hotkey-langs.patch (9 KiB) 
 apps/lang/slovak.lang   |  100 ------------------------------------------------
 apps/lang/english.lang  |   50 ++++++++++++------------
 apps/lang/czech.lang    |  100 ------------------------------------------------
 apps/lang/italiano.lang |  100 ------------------------------------------------
 4 files changed, 26 insertions(+), 324 deletions(-)

Loading...