Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11257 - Sansa AMS: DMA recording

Attached to Project: Rockbox
Opened by Rafaël Carré (funman) - Sunday, 09 May 2010, 12:20 GMT+2
Last edited by Rafaël Carré (funman) - Thursday, 13 May 2010, 07:26 GMT+2
Task Type Patches
Category Recording
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Tested on Fuzev2

I hear a big hiss at the start, and the recordings sound really bad

When watching a silent recording in audacity I see a small bar at a frequency which is the calling rate of the DMA callback.
   recording-dma.diff (6.6 KiB)
 b/firmware/target/arm/as3525/pcm-as3525.c |  158 ++++++++++--------------------
 b/firmware/target/arm/mmu-arm.S           |    2 
 2 files changed, 53 insertions(+), 107 deletions(-)

This task depends upon

Closed by  Rafaël Carré (funman)
Thursday, 13 May 2010, 07:26 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r25980
Comment by Rafaël Carré (funman) - Wednesday, 12 May 2010, 10:38 GMT+2
fixes stupid errors

seems to work fine
   recording-dma-v2.diff (7.3 KiB)
 b/firmware/target/arm/as3525/pcm-as3525.c |  176 +++++++++++++-----------------
 b/firmware/target/arm/mmu-arm.S           |    2 
 2 files changed, 77 insertions(+), 101 deletions(-)

Comment by Rafaël Carré (funman) - Wednesday, 12 May 2010, 11:44 GMT+2
avoid transferring 8188 bytes and then 4
fix pcm_rec_dma_get_peak_buffer
use 4 words transfer burst
   recording-dma-v3.diff (7.6 KiB)
 b/firmware/target/arm/as3525/pcm-as3525.c |  181 ++++++++++++++----------------
 b/firmware/target/arm/mmu-arm.S           |    2 
 2 files changed, 86 insertions(+), 97 deletions(-)

Loading...