Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11260 - lets keybox import its database from an external text file

Attached to Project: Rockbox
Opened by Gerhard Zintel (Gerbil) - Wednesday, 12 May 2010, 01:16 GMT+2
Last edited by Nils Wallménius (nls) - Wednesday, 18 August 2010, 11:42 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch is an improvement to the keybox plugin. It lets you import new data from the file "keybox.txt". The file must reside in the same directory as the "keybox.dat" file. For each new entry, three consecutive lines with Title, User and Password information is read from the file and imported into the database.

This patch avoids the need to use the internal text editor to fill the encrypted data base.
This task depends upon

Closed by  Nils Wallménius (nls)
Wednesday, 18 August 2010, 11:42 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  I'm sorry but this is a too great security risk and even reisk lulling users into false security.
Comment by Gerhard Zintel (Gerbil) - Wednesday, 12 May 2010, 01:19 GMT+2
It seems that the attachment of the file has not worked
   keybox.diff (4.9 KiB) 
 apps/plugins/keybox.c |  107 +++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 89 insertions(+), 18 deletions(-)

Comment by Gerhard Zintel (Gerbil) - Wednesday, 12 May 2010, 15:54 GMT+2
The new diff file contains the above attached patch and additionally an update for the manual in keybox.tex.

Tested in the Sansa e200 player in the simulator.
   keybox.diff (6.5 KiB) 
 manual/plugins/keybox.tex |   22 ++++++++-
 apps/plugins/keybox.c     |  107 ++++++++++++++++++++++++++++++++++++++--------
 2 files changed, 109 insertions(+), 20 deletions(-)

Comment by Gerhard Zintel (Gerbil) - Thursday, 13 May 2010, 13:08 GMT+2
Reworked version of patch with:

* more consistent splash time settings
* asks the user if he wants to delete the unencrypted file and delete it if YES
* manual: including hint, that the deleted file could be reconstructed from raw data on disk

Furthermore I have found a bug in keybox.c. If data is resetted in function "reset"
rb->gui_synclist_set_nb_items(&kb_list, 0);
must be called additionally to reset the number of items in kb_list too.
   keybox.diff (7.2 KiB) 
 manual/plugins/keybox.tex |   25 ++++++++-
 apps/plugins/keybox.c     |  119 +++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 124 insertions(+), 20 deletions(-)

Comment by Gerhard Zintel (Gerbil) - Friday, 14 May 2010, 13:06 GMT+2
excluded the reset bug patch from above patch (rb->gui_synclist_set_nb_items(&kb_list, 0);). For that patch (11272) has been applied meanwhile into Rockbox I've deleted it from this ( FS#11260 ) one.
   keybox.diff (7 KiB) 
 manual/plugins/keybox.tex |   25 ++++++++-
 apps/plugins/keybox.c     |  118 ++++++++++++++++++++++++++++++++++++++--------
 2 files changed, 123 insertions(+), 20 deletions(-)

Loading...