Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11263 - Radio art

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Wednesday, 12 May 2010, 17:15 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 16 May 2010, 13:14 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This makes the %Cl and %C tags work in the fm screen skin!

to use it you must be in presets mode, and have a preset file loaded. then in the fmpresets folder you need one .bmp for each station named the same as it is in the presets file.

this first version only loads bmp...
   radioart.1.diff (3.8 KiB) 
 apps/recorder/radio.c               |   37 ++++++++++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_display.c |    8 +++++--
 apps/appevents.h                    |    3 +-
 apps/playback.c                     |    1 
 apps/buffering.c                    |    1 
 5 files changed, 46 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 16 May 2010, 13:14 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  in r26078
Comment by Michael Chicoine (mc2739) - Thursday, 13 May 2010, 04:42 GMT+2
Updated patch to correct compile errors (changed strncpy to strlcpy)
   radioart.2.diff (3.8 KiB) 
 apps/recorder/radio.c               |   37 ++++++++++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_display.c |    8 +++++--
 apps/appevents.h                    |    3 +-
 apps/playback.c                     |    1 
 apps/buffering.c                    |    1 
 5 files changed, 46 insertions(+), 4 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Thursday, 13 May 2010, 13:00 GMT+2
this version stores 10 images so there should be no load at all when changing stations if the image was loaded already.
It will fail if more than 10 images need to be loaded though (simple fix but running out now)
   radioart.2.diff (4.7 KiB) 
 apps/recorder/radio.c               |   62 ++++++++++++++++++++++++++++++++++++
 apps/gui/skin_engine/skin_display.c |   11 +++++-
 apps/appevents.h                    |    3 +
 apps/playback.c                     |    1 
 apps/buffering.c                    |    1 
 5 files changed, 74 insertions(+), 4 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Thursday, 13 May 2010, 16:52 GMT+2
Fix %?C not working and %C for radio not working in sbs.

dump the oldest image if we need to load more than 10, or there isnt enough room on the buffer (pretty much untested).

This is commitable now except going into the recording screen then back into fm with a station expecting an image will very likely crash the player!

Also seach for .jpg in the same folder (.bmp first though.. order can be changed)
   radioart.3.diff (7.1 KiB) 
 apps/recorder/radio.c               |  103 ++++++++++++++++++++++++++++++++++++
 apps/recorder/radio.h               |    4 +
 apps/gui/skin_engine/skin_tokens.c  |   14 ++++
 apps/gui/skin_engine/skin_display.c |   11 +++
 apps/appevents.h                    |    3 -
 apps/playback.c                     |    1 
 apps/buffering.c                    |    1 
 7 files changed, 131 insertions(+), 6 deletions(-)

Comment by Michael Chicoine (mc2739) - Thursday, 13 May 2010, 19:47 GMT+2
%?C and .jpg support tested - no problems detected

Entering recording screen from fm screen caused: Data abort at 00008ea4 (0)
This happens even after stopping the fm radio. If you start playback and then go to the recording screen, it does not crash.
Comment by Jonathan Gordon (jdgordon) - Friday, 14 May 2010, 04:26 GMT+2
thanks, yeah that is what I was expecting. I'm not entirely sure how to make this perfectly safe but I'll play today if I get a chance
Comment by Jonathan Gordon (jdgordon) - Friday, 14 May 2010, 08:11 GMT+2
This should fix the recording problems. It isnt really as clean as I would like though... please let me know if it does work (radioart should stop working as soon as you try recording. stopping the recording should make it work again)
   radioart.4.diff (9.4 KiB) 
 apps/recorder/radio.c               |  131 ++++++++++++++++++++++++++++++++++++
 apps/recorder/radio.h               |    4 +
 apps/recorder/pcm_record.c          |    3 
 apps/gui/skin_engine/skin_tokens.c  |   14 +++
 apps/gui/skin_engine/skin_display.c |   11 ++-
 apps/appevents.h                    |    8 +-
 apps/playback.c                     |    1 
 apps/buffering.c                    |    1 
 firmware/export/events.h            |    1 
 9 files changed, 168 insertions(+), 6 deletions(-)

Comment by Michael Chicoine (mc2739) - Saturday, 15 May 2010, 02:24 GMT+2
No more crashes with this latest patch. On e200, when recording, it goes to the recording screen, so no radioart anyway.

Loading...