Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11283 - Integrate byte swap of ata word into ata-as-coldfire.S

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Monday, 17 May 2010, 13:18 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Monday, 17 May 2010, 17:22 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Coldfire-based
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

MPIO HD200 has byte swapped ata lines, all other coldfire based devices uses plain connection.
   ata-as-coldfire.diff (19 KiB) 
 b/firmware/SOURCES                           |    2 
 b/firmware/export/config/mpiohd200.h         |    1 
 b/firmware/target/coldfire/ata-as-coldfire.S |  371 ++++++++++++++++++++++++++-
 b/firmware/target/coldfire/mpio/ata-target.h |    2 
 4 files changed, 368 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Monday, 17 May 2010, 17:22 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  In r26105.
Comment by Marcin Bukat (MarcinBukat) - Monday, 17 May 2010, 14:15 GMT+2
New version with byteswaps as gas macros
   ata-as-coldfire.diff (14.2 KiB) 
 b/firmware/export/config/mpiohd200.h         |    1 
 b/firmware/SOURCES                           |   33 ---
 b/firmware/target/coldfire/ata-as-coldfire.S |  230 ++++++++++++++++++++++++++-
 b/firmware/target/coldfire/mpio/ata-target.h |    2 
 4 files changed, 229 insertions(+), 37 deletions(-)

Comment by Maurus Cuelenaere (mcuelenaere) - Monday, 17 May 2010, 17:09 GMT+2
On a not-so-related note: I'd prefer something like ATA_SWAP_WORDS instead of SWAP_WORDS, perhaps something to commit separately?
Grep reported that the only users of SWAP_WORDS are ata.c, coldfire/mpio/ata-target.h and sh/archos/ata-target.h; so some minor sed'ing should do the trick.

If you're not interested, I'll do the commit (after this is in of course).
Comment by Maurus Cuelenaere (mcuelenaere) - Monday, 17 May 2010, 17:10 GMT+2
Hmm, I just noticed you committed this as r26105, shouldn't this be closed?

Loading...