Rockbox

Tasklist

FS#11283 - Integrate byte swap of ata word into ata-as-coldfire.S

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Monday, 17 May 2010, 11:18 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Monday, 17 May 2010, 15:22 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System Coldfire-based
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

MPIO HD200 has byte swapped ata lines, all other coldfire based devices uses plain connection.
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Monday, 17 May 2010, 15:22 GMT
Reason for closing:  Accepted
Additional comments about closing:  In r26105.
Comment by Marcin Bukat (MarcinBukat) - Monday, 17 May 2010, 12:15 GMT
New version with byteswaps as gas macros
Comment by Maurus Cuelenaere (mcuelenaere) - Monday, 17 May 2010, 15:09 GMT
On a not-so-related note: I'd prefer something like ATA_SWAP_WORDS instead of SWAP_WORDS, perhaps something to commit separately?
Grep reported that the only users of SWAP_WORDS are ata.c, coldfire/mpio/ata-target.h and sh/archos/ata-target.h; so some minor sed'ing should do the trick.

If you're not interested, I'll do the commit (after this is in of course).
Comment by Maurus Cuelenaere (mcuelenaere) - Monday, 17 May 2010, 15:10 GMT
Hmm, I just noticed you committed this as r26105, shouldn't this be closed?

Loading...