Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11308 - PictureFlow shortcut at the Root Menu

Attached to Project: Rockbox
Opened by Daniel Kalle (DonDan) - Monday, 24 May 2010, 14:28 GMT+2
Last edited by Paul Louden (Llorean) - Monday, 24 May 2010, 21:54 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

I have created a patch that provides a shortcut at the Root Menu for the PictureFlow plugin.

This is sort of complementary to the " PictureFlow - WPS Integration" patch from csavery.
http://www.rockbox.org/tracker/task/11270

This patch could be modified to provide shortcuts to other plugins.
It essentially makes a new entry in the root menu and launches the PictureFlow plugin.
Additionally it checks after exiting the plugin if there is some song playing, and decide based on this information if it goes back to the previous menu or if it goes directly to the wps.

This patch will never reach the svn because "Configurable menus" is part of the NoDo list.
But for those that want some kind of shortcut for plugins especially for the PictureFlow plugin this is still an option!

I tested this with the 26249 revision on a Sansa Fuze v2.
   pictureflow-shortcut-v1.diff (2.2 KiB) 
 src/apps/root_menu.c |   21 +++++++++++++++++++++
 src/apps/root_menu.h |    1 +
 2 files changed, 22 insertions(+)

This task depends upon

Closed by  Paul Louden (Llorean)
Monday, 24 May 2010, 21:54 GMT+2
Reason for closing:  Invalid
Additional comments about closing:  Flyspray is for patches that are working toward inclusion.

To be reopened if the situation changes, I suppose.
Comment by Daniel Kalle (DonDan) - Monday, 24 May 2010, 17:45 GMT+2
Sorry, forgot one semicolon...(the previous v1 patch won't compile).

v2 is working!
   pictureflow-shortcut-v2.diff (2.2 KiB) 
 src/apps/root_menu.c |   21 +++++++++++++++++++++
 src/apps/root_menu.h |    1 +
 2 files changed, 22 insertions(+)

Comment by Jonathan Gordon (jdgordon) - Monday, 24 May 2010, 17:47 GMT+2
VERY unlikely to be accepted. Most devs dont use the database (let alone pictureflow) so there wont be much love for this.
Comment by Alex Parker (BigBambi) - Monday, 24 May 2010, 19:35 GMT+2
Also, flyspray should be used only for things that are trying to get into SVN. If this will not make it, then it should be closed.

Loading...