Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11309 - Minor asm changes to codecs

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Monday, 24 May 2010, 15:01 GMT+2
Last edited by Andree Buschmann (Buschel) - Saturday, 29 May 2010, 16:17 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To Andree Buschmann (Buschel)
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds some minor changes to libmad, libmpc and libatrac. It incorporates  FS#11235  (libmad optimization for ARM9).

Speed up on PP502x for mpc and atrac3 is ~0.05-0.1 MHz -- not much, but reproducible slightly faster. The speed of libmad on PP502x is same as svn, but for >=ARM9 it was reported to be ~0.2 MHz faster.
   codec_asm_v01.patch (8.8 KiB) 
 apps/codecs/libmad/synth.c            |   36 ++++++++++----------
 apps/codecs/libmusepack/mpcdec_math.h |   59 +++++++++++++++++-----------------
 apps/codecs/libatrac/fixp_math.h      |   40 ++++++++++++-----------
 3 files changed, 71 insertions(+), 64 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Saturday, 29 May 2010, 16:17 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  Speed-up is only minor on PP502x , but speed was reported to be minor slower on ARM9. So, drop this change.
Comment by Andree Buschmann (Buschel) - Monday, 24 May 2010, 19:26 GMT+2
New version which uses appropriate clobber lists in libmad's asm routines. Also do some reformatting.
   codec_asm_v02.patch (10 KiB) 
 apps/codecs/libmad/synth.c            |   90 +++++++++++++++++-----------------
 apps/codecs/libmusepack/mpcdec_math.h |   59 +++++++++++-----------
 apps/codecs/libatrac/fixp_math.h      |   40 ++++++++-------
 3 files changed, 99 insertions(+), 90 deletions(-)

Loading...