Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11313 - Add composer to track info screen.

Attached to Project: Rockbox
Opened by Chris Savery (csavery) - Monday, 24 May 2010, 18:26 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 30 May 2010, 17:26 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch exposes the composer tag in the track info screen (at the bottom, only if available).
I would have preferred it up under artist tag but it would have changed all the other tags too so I decided to keep it simple.
This requires a new lang id as well which means if it doesn't get into svn then we'll have to re-sync it more often.
Patched against r26251 and tested on Fuze v2 and Sim.
   trackinfo-composer.patch (1.3 KiB) 
 src/apps/screens.c         |   11 ++++++++++-
 src/apps/lang/english.lang |   14 ++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 30 May 2010, 17:26 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  thanks. in 26409.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 25 May 2010, 04:35 GMT+2
we are in freeze now, but after 3.6 annoy someone to accept this. alternativly, if you would like to fix it to not hardcode those position numbers that would be great :)
Comment by Chris Savery (csavery) - Tuesday, 25 May 2010, 08:04 GMT+2
Updated, as suggested. The track info lines are no longer hard coded to position but use the language id instead as lookup.
This makes it easy to add new tags and re-arrange the order of tags.
I've moved composer up to position under artist.
Patch against r26251 and tested on Fuze v2.
   trackinfo-composer-2.patch (4.5 KiB) 
 src/apps/screens.c         |   44 ++++++++++++++++++++++----------------------
 src/apps/lang/english.lang |   14 ++++++++++++++
 2 files changed, 36 insertions(+), 22 deletions(-)

Loading...